Re: [PATCH 1/1] mfd: remove unnecessary check

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] mfd: remove unnecessary check
Date	Thu, 02 Jul 2015 02:20:01 +0200
Message-ID	<pHAop-3OA-3@gated-at.bofh.it> (permalink)
References	<pH2G6-1wN-5@gated-at.bofh.it> <pHkWm-2ey-9@gated-at.bofh.it> <pHkWm-2ey-7@gated-at.bofh.it> <pHl63-2i0-35@gated-at.bofh.it> <pHqS5-6ae-13@gated-at.bofh.it>
X-Original-To	Lee Jones <lee.jones@linaro.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=SliuR5fdBXCY2ikBsDmyRluxtQjsGu9i54/PYy8f2uc=; b=fRQrBeq0wB23IjvviHYgfn2DLQE7hpvcml9mHBi2kDxwB2LMD18pi/UVRFR3yD7Os0 Rouiz9JFxEoQG7Aqa0sBivS+Onf2KKPIlOji/jZoLIW1Dh9wo0qr0ZtyBb7v/oY4tRm9 S2x14LfLYWdOeLkMm0EsrkWuEPqdAJER02EPF6IsllsBCGUs+xRdSQEOVQk9n0XFvUaw VxBWhVY6zxbP5F+rJ8ORryP1cxICvbEbFGnPF7wBLrtnv7sH/5ilJY8cYnMAnQCqkPUl L9HKkFPtipuX5Vc1/xATkUEhd0HyhD3ArlZiZCEOgilM/2uNyMpeN3+Nc4fJEpS3dLML iAXA==
MIME-Version	1.0
X-Received	by 10.52.185.69 with SMTP id fa5mr28271344vdc.62.1435796097070; Wed, 01 Jul 2015 17:14:57 -0700 (PDT)
X-Google-Sender-Auth	LtVuk8k8pYV7GQurt_yl9Za3UWA
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Krzysztof Kozlowski <k.kozlowski@samsung.com>, Maninder Singh <maninder1.s@samsung.com>, sameo@linux.intel.com, linux-kernel@vger.kernel.org, pankaj.m@samsung.com
X-Original-Date	Thu, 2 Jul 2015 09:14:57 +0900
X-Original-Message-ID	<CAJKOXPd9bujexAFq03Noz1Qc-VpmO2VTdoY5sEWcYBvTHA1avQ@mail.gmail.com>
X-Original-References	<1435666326-10039-1-git-send-email-maninder1.s@samsung.com> <20150701073950.GB3210@x1> <20150701074053.GC3210@x1> <CAJKOXPdp_zjozfjjtXJ19GojGfkvnzsStdhhji_m3MeVCfc+Aw@mail.gmail.com> <20150701140826.GM3210@x1>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1175623

Show key headers only | View raw

2015-07-01 23:08 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
>
>> 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
>> > On Wed, 01 Jul 2015, Lee Jones wrote:
>> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
>> >>
>> >> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >> >     and all other checks in file.
>> >> >  o Removing redundant check of pdata, because we already
>> >> >     check for pdata, and also derefernced before this check
>> >> >
>> >> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> >> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> >> > ---
>> >> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> Applied, with a properly formatted subject line.
>> >
>> > Should have probably been more forthcomming with some advice.
>> >
>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>> > the accepted format is.
>>
>> ... and a spell-check could be useful as well :). The reviewed-by tag
>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>> so I think it should be dropped.
>
> Fair points.  Patch dropped.

I meant the reviewed-by tag should be dropped :) .

So now... Maninder Singh, could you resent the patch with this minor
issues fixed?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] mfd: remove unnecessary check Lee Jones <lee.jones@linaro.org> - 2015-07-01 09:50 +0200
  Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-01 10:00 +0200
    Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-02 02:20 +0200

csiph-web