Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1175044 > unrolled thread

Re: [PATCH 1/1] mfd: remove unnecessary check

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] mfd: remove unnecessary check Lee Jones <lee.jones@linaro.org> - 2015-07-01 09:50 +0200
    Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-01 10:00 +0200
      Re: [PATCH 1/1] mfd: remove unnecessary check Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-07-02 02:20 +0200

#1175044 — Re: [PATCH 1/1] mfd: remove unnecessary check

On Wed, 01 Jul 2015, Lee Jones wrote:
> On Tue, 30 Jun 2015, Maninder Singh wrote:
> 
> >  o Making pdata NULL check to (!pdata) as coding statndard
> > 	and all other checks in file.
> >  o Removing redundant check of pdata, because we already
> > 	check for pdata, and also derefernced before this check
> > 
> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> > ---
> >  drivers/mfd/t7l66xb.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Applied, with a properly formatted subject line.

Should have probably been more forthcomming with some advice.

Next time, please use `git log --oneline -- <subsystem>` to see what
the accepted format is.

> > diff --git a/drivers/mfd/t7l66xb.c b/drivers/mfd/t7l66xb.c
> > index c09fb5d..854b05f 100644
> > --- a/drivers/mfd/t7l66xb.c
> > +++ b/drivers/mfd/t7l66xb.c
> > @@ -318,7 +318,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> >  	struct resource *iomem, *rscr;
> >  	int ret;
> >  
> > -	if (pdata == NULL)
> > +	if (!pdata)
> >  		return -EINVAL;
> >  
> >  	iomem = platform_get_resource(dev, IORESOURCE_MEM, 0);
> > @@ -371,7 +371,7 @@ static int t7l66xb_probe(struct platform_device *dev)
> >  
> >  	clk_prepare_enable(t7l66xb->clk48m);
> >  
> > -	if (pdata && pdata->enable)
> > +	if (pdata->enable)
> >  		pdata->enable(dev);
> >  
> >  	/* Mask all interrupts */
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1175059

2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Lee Jones wrote:
>> On Tue, 30 Jun 2015, Maninder Singh wrote:
>>
>> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >     and all other checks in file.
>> >  o Removing redundant check of pdata, because we already
>> >     check for pdata, and also derefernced before this check
>> >
>> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> > ---
>> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Applied, with a properly formatted subject line.
>
> Should have probably been more forthcomming with some advice.
>
> Next time, please use `git log --oneline -- <subsystem>` to see what
> the accepted format is.

... and a spell-check could be useful as well :). The reviewed-by tag
was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
so I think it should be dropped.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1175623

2015-07-01 23:08 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
> On Wed, 01 Jul 2015, Krzysztof Kozlowski wrote:
>
>> 2015-07-01 16:40 GMT+09:00 Lee Jones <lee.jones@linaro.org>:
>> > On Wed, 01 Jul 2015, Lee Jones wrote:
>> >> On Tue, 30 Jun 2015, Maninder Singh wrote:
>> >>
>> >> >  o Making pdata NULL check to (!pdata) as coding statndard
>> >> >     and all other checks in file.
>> >> >  o Removing redundant check of pdata, because we already
>> >> >     check for pdata, and also derefernced before this check
>> >> >
>> >> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
>> >> > Reviewed-by: Vaneet Narang <v.narang@samsung.com>
>> >> > ---
>> >> >  drivers/mfd/t7l66xb.c |    4 ++--
>> >> >  1 file changed, 2 insertions(+), 2 deletions(-)
>> >>
>> >> Applied, with a properly formatted subject line.
>> >
>> > Should have probably been more forthcomming with some advice.
>> >
>> > Next time, please use `git log --oneline -- <subsystem>` to see what
>> > the accepted format is.
>>
>> ... and a spell-check could be useful as well :). The reviewed-by tag
>> was not sent on LKML and the person (Vaneet Narang) was not even CC-ed
>> so I think it should be dropped.
>
> Fair points.  Patch dropped.

I meant the reviewed-by tag should be dropped :) .

So now... Maninder Singh, could you resent the patch with this minor
issues fixed?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web