Re: [PATCH 0/8] Security: Provide unioned file support

From	Miklos Szeredi <miklos@szeredi.hu>
Newsgroups	linux.kernel
Subject	Re: [PATCH 0/8] Security: Provide unioned file support
Date	2015-06-19 10:40 +0200
Message-ID	<pD00a-25F-19@gated-at.bofh.it> (permalink)
References	(1 earlier) <pCYUp-zA-3@gated-at.bofh.it> <pCZns-17v-23@gated-at.bofh.it> <pCZns-17v-21@gated-at.bofh.it> <pCZGN-1Jh-1@gated-at.bofh.it> <pCZQu-1Uu-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 19, 2015 at 10:29 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> Directory, probably?
>
>> -     dentry = lookup_one_len(name, parent->dentry, namelen);
>> +     dentry = lookup_one_len(name, parent, namelen);
>
> ... it would better be one.

My point is: without a bloody accessor, there's no way to warn if the
use is illegal (i.e. nondirectory).

Maybe we won't need file->f_dentry, but we do need a way to WARN about
abuse (which there IS probably a significant number already and
nothing preventing more).

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 09:30 +0200
  Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 10:00 +0200
    Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:20 +0200
      Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 10:30 +0200
        Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:40 +0200
  Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:00 +0200
    Re: [PATCH 0/8] Security: Provide unioned file support David Howells <dhowells@redhat.com> - 2015-06-19 16:10 +0200

csiph-web