Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1168617
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Miklos Szeredi <miklos@szeredi.hu> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/8] Security: Provide unioned file support |
| Date | Fri, 19 Jun 2015 10:40:02 +0200 |
| Message-ID | <pD00a-25F-19@gated-at.bofh.it> (permalink) |
| References | <pCIcV-1t5-3@gated-at.bofh.it> <pCYUp-zA-3@gated-at.bofh.it> <pCZns-17v-23@gated-at.bofh.it> <pCZns-17v-21@gated-at.bofh.it> <pCZGN-1Jh-1@gated-at.bofh.it> <pCZQu-1Uu-11@gated-at.bofh.it> |
| X-Original-To | Al Viro <viro@zeniv.linux.org.uk> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=6686BbIdnApabLA2+/FGFCIMSW2VvDE/UUpufgNSPzg=; b=cO1S9xJKfk2Z/gbI/sgkirpNQHt/YRINyXaEEK/C69OMUicF8e+raRnye3WeRUM3g5 LOsY5nbohYC662damY5Z0rRlkYIC2PMd5dSl5eC0igv/AgLE78Wu5ZXteAhR6B9Tp1Ww hH+jwb8YDhpbPMl4JgUBR3z7iGIX4Vr65SPyQ= |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=6686BbIdnApabLA2+/FGFCIMSW2VvDE/UUpufgNSPzg=; b=HheBQWS6qMk1nzfswH185LoZuQYrPjOX5rFJpvXrR0FuJvCIgI92z3mYhgcIzIwyl6 HbN/CFtSwPcn0y+OU6L4fTRaMIFAz7fQQlmuZSfs5zi2W/70Ib3IGCuRp0TChN565Y4e eEezhbTEt8DFD/sLFOhphBJAEKnMLTwIWd3bw0XH7XbUEM7PfmznzbsnMBaRFLrV2t40 5WpHfplC9Ho/eX8toHGzXfY1YxGyiUihXlrOIULfzGCml3kmzKOO/Z4cYBsgkTlTPmHm 9ob1ThTehcuQ7glt/NKG2lClOBgHjcOygv8EFXFa/ADYFYhJGll6Zwlaxoo2ZamM8fPR Ih5g== |
| X-Gm-Message-State | ALoCoQmgd1bZgNqjkmCm0fVd1T7WZZxzfa3rrzBx+n/2cc4QxIX6+Ene3RcXfyhHQ2B7dKK6h5n/ |
| MIME-Version | 1.0 |
| X-Received | by 10.140.102.180 with SMTP id w49mr19685700qge.82.1434702963621; Fri, 19 Jun 2015 01:36:03 -0700 (PDT) |
| X-Originating-IP | [217.173.38.102] |
| Content-Type | text/plain; charset=UTF-8 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 22 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | David Howells <dhowells@redhat.com>, sds@tycho.nsa.gov, Linux-Fsdevel <linux-fsdevel@vger.kernel.org>, linux-security-module@vger.kernel.org, "linux-unionfs@vger.kernel.org" <linux-unionfs@vger.kernel.org>, Kernel Mailing List <linux-kernel@vger.kernel.org> |
| X-Original-Date | Fri, 19 Jun 2015 10:36:03 +0200 |
| X-Original-Message-ID | <CAJfpeguSPJduSF4wuTHZUbvnxOeNFnT40WQXM_+i6S8mHzvWLQ@mail.gmail.com> |
| X-Original-References | <20150618133215.12722.70352.stgit@warthog.procyon.org.uk> <20150619072015.GH17109@ZenIV.linux.org.uk> <CAJfpeguZq-1C_hnCcyrW3MCcpP4Bwe+L4gpWaOeJCqa1q8j4Hg@mail.gmail.com> <20150619075903.GI17109@ZenIV.linux.org.uk> <20150619081128.GA24181@tucsk> <20150619082928.GJ17109@ZenIV.linux.org.uk> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | aioe.org linux.kernel:1168617 |
Show key headers only | View raw
On Fri, Jun 19, 2015 at 10:29 AM, Al Viro <viro@zeniv.linux.org.uk> wrote: > Directory, probably? > >> - dentry = lookup_one_len(name, parent->dentry, namelen); >> + dentry = lookup_one_len(name, parent, namelen); > > ... it would better be one. My point is: without a bloody accessor, there's no way to warn if the use is illegal (i.e. nondirectory). Maybe we won't need file->f_dentry, but we do need a way to WARN about abuse (which there IS probably a significant number already and nothing preventing more). Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 09:30 +0200
Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 10:00 +0200
Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:20 +0200
Re: [PATCH 0/8] Security: Provide unioned file support Al Viro <viro@ZenIV.linux.org.uk> - 2015-06-19 10:30 +0200
Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:40 +0200
Re: [PATCH 0/8] Security: Provide unioned file support Miklos Szeredi <miklos@szeredi.hu> - 2015-06-19 10:00 +0200
Re: [PATCH 0/8] Security: Provide unioned file support David Howells <dhowells@redhat.com> - 2015-06-19 16:10 +0200
csiph-web