Path: csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From: Miklos Szeredi <miklos@szeredi.hu>
Newsgroups: linux.kernel
Subject: Re: [PATCH 0/8] Security: Provide unioned file support
Date: Fri, 19 Jun 2015 10:40:02 +0200
Message-ID: <pD00a-25F-19@gated-at.bofh.it>
References: <pCIcV-1t5-3@gated-at.bofh.it> <pCYUp-zA-3@gated-at.bofh.it> <pCZns-17v-23@gated-at.bofh.it> <pCZns-17v-21@gated-at.bofh.it> <pCZGN-1Jh-1@gated-at.bofh.it> <pCZQu-1Uu-11@gated-at.bofh.it>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Sender: robomod@news.nic.it
Approved: robomod@news.nic.it
Lines: 22
Organization: linux.* mail to news gateway
Xref: aioe.org linux.kernel:1168617

On Fri, Jun 19, 2015 at 10:29 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> Directory, probably?
>
>> -     dentry = lookup_one_len(name, parent->dentry, namelen);
>> +     dentry = lookup_one_len(name, parent, namelen);
>
> ... it would better be one.

My point is: without a bloody accessor, there's no way to warn if the
use is illegal (i.e. nondirectory).

Maybe we won't need file->f_dentry, but we do need a way to WARN about
abuse (which there IS probably a significant number already and
nothing preventing more).

Thanks,
Miklos
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/