Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168271

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

Show all headers | View raw

On 6/18/15 1:59 PM, Lukas Wunner wrote:
> E.g. the Debian "linux-tools" package makes use of that feature:
>
> 	MAKE_PERF := $(MAKE) prefix=/usr V=1 ARCH=$(KERNEL_ARCH_PERF) EXTRA_WARNINGS=-Wno-error
>
> Source: http://anonscm.debian.org/viewvc/kernel/dists/trunk/linux-tools/debian/build/tools/perf/Makefile?view=markup (line 29)
>
>
> The "prefix" parameter is handed down from Makefile.perf to Makefile.build
> because it's invoked with $(MAKE), so the command line parameters are
> inherited to Makefile.build:
>
> 	$(Q)$(MAKE) $(build)=perf
>
> Source: https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/tools/perf/Makefile.perf#n282
>
>
> That "prefix" feature is broken in all 4.1 release candidates because a

It worked for me last week with OL6.

I created a standalone perf rpm with 4.1-rc6; it builds just fine with 
_prefix (rpm variable) set to /usr:

%build
# prepare directories
rm -rf $RPM_BUILD_ROOT

cd perf-%{kversion}

%global perf_make \
   make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 
HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix}

%{perf_make} DESTDIR=$RPM_BUILD_ROOT all

###
### install
###

%install
[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT
cd perf-%{kversion}
%{perf_make} DESTDIR=$RPM_BUILD_ROOT lib=%{_lib} install man



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Jiri Olsa <jolsa@redhat.com> - 2015-06-18 21:30 +0200
  Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:10 +0200
    Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage  if prefix= is specified David Ahern <dsahern@gmail.com> - 2015-06-18 22:30 +0200
      Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:50 +0200

csiph-web