Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1168237

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

Show all headers | View raw

On Thu, Jun 18, 2015 at 01:00:32PM +0200, Lukas Wunner wrote:
> Invoking Makefile.perf with prefix= breaks the build since Makefile.perf
> hands that variable down to Makefile.build where it overrides
>     prefix       := $(subst ./,,$(OUTPUT)$(dir)/)
> 
> leading to errors like this:
>     No rule to make target '/usrabspath.o', needed by '/usrlibperf-in.o'

hum, what specific make command is failing?

jirka

> 
> Fixes: c819e2cf2eb6f65d3208d195d7a0edef6108d5
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
> ---
>  tools/build/Makefile.build | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/build/Makefile.build b/tools/build/Makefile.build
> index 10df572..98cfc38 100644
> --- a/tools/build/Makefile.build
> +++ b/tools/build/Makefile.build
> @@ -94,12 +94,12 @@ obj-y        := $(patsubst %/, %/$(obj)-in.o, $(obj-y))
>  subdir-obj-y := $(filter %/$(obj)-in.o, $(obj-y))
>  
>  # '$(OUTPUT)/dir' prefix to all objects
> -prefix       := $(subst ./,,$(OUTPUT)$(dir)/)
> -obj-y        := $(addprefix $(prefix),$(obj-y))
> -subdir-obj-y := $(addprefix $(prefix),$(subdir-obj-y))
> +objprefix    := $(subst ./,,$(OUTPUT)$(dir)/)
> +obj-y        := $(addprefix $(objprefix),$(obj-y))
> +subdir-obj-y := $(addprefix $(objprefix),$(subdir-obj-y))
>  
>  # Final '$(obj)-in.o' object
> -in-target := $(prefix)$(obj)-in.o
> +in-target := $(objprefix)$(obj)-in.o
>  
>  PHONY += $(subdir-y)
>  
> -- 
> 1.8.5.2 (Apple Git-48)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Jiri Olsa <jolsa@redhat.com> - 2015-06-18 21:30 +0200
  Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:10 +0200
    Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage  if prefix= is specified David Ahern <dsahern@gmail.com> - 2015-06-18 22:30 +0200
      Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:50 +0200

csiph-web