Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified

From	Lukas Wunner <lukas@wunner.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if prefix= is specified
Date	2015-06-18 22:50 +0200
Message-ID	<pCOV5-2I1-9@gated-at.bofh.it> (permalink)
References	<pCNFD-10E-5@gated-at.bofh.it> <pCNFD-10E-3@gated-at.bofh.it> <pCOin-1Z7-17@gated-at.bofh.it> <pCOBH-2ly-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi David,

On Thu, Jun 18, 2015 at 02:26:25PM -0600, David Ahern wrote:
> It worked for me last week with OL6.
> I created a standalone perf rpm with 4.1-rc6; it builds just fine with
> _prefix (rpm variable) set to /usr:
[...]
> %global perf_make \
>   make -s -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1
> NO_GTK2=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=%{_prefix}
> %{perf_make} DESTDIR=$RPM_BUILD_ROOT all

You're not invoking tools/perf/Makefile.perf but tools/perf/Makefile
and I would say this in line 18 avoids that prefix= is passed down
to Makefile.perf:

	# We don't want to pass along options like -j:
	unexport MAKEFLAGS

Sources:
https://www.gnu.org/software/make/manual/html_node/Options_002fRecursion.html
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/tools/perf/Makefile#n18

So the prefix parameter should have no effect at all in your case,
no matter to what you set it.

Best regards,

Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Jiri Olsa <jolsa@redhat.com> - 2015-06-18 21:30 +0200
  Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:10 +0200
    Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage  if prefix= is specified David Ahern <dsahern@gmail.com> - 2015-06-18 22:30 +0200
      Re: [PATCH regression 4.0 -> 4.1] tools perf: Fix build breakage if  prefix= is specified Lukas Wunner <lukas@wunner.de> - 2015-06-18 22:50 +0200

csiph-web