Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1739631 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-09-26 09:40 +0200 |
| Last post | 2017-09-27 16:30 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:40 +0200
Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Yuval Shaia <yuval.shaia@oracle.com> - 2017-09-26 10:00 +0200
Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Leon Romanovsky <leon@kernel.org> - 2017-09-26 10:50 +0200
Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Doug Ledford <dledford@redhat.com> - 2017-09-27 16:30 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-26 09:40 +0200 |
| Subject | [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines |
| Message-ID | <utSDg-1Ff-15@gated-at.bofh.it> |
pr_err() messages should end with a new-line to avoid other messages
being concatenated.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
changes in v2 :
Add same changes for 'ocrdma_hw.c'
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index dcb5942..b5cb69f 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -1090,7 +1090,7 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe)
rsp = &mqe->u.rsp;
if (cqe_status || ext_status) {
- pr_err("%s() cqe_status=0x%x, ext_status=0x%x,",
+ pr_err("%s() cqe_status=0x%x, ext_status=0x%x,\n",
__func__, cqe_status, ext_status);
if (rsp) {
/* This is for embedded cmds. */
diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
index 66056f9..e528d7a 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
@@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
if (reset) {
status = ocrdma_mbx_rdma_stats(dev, true);
if (status) {
- pr_err("Failed to reset stats = %d", status);
+ pr_err("Failed to reset stats = %d\n", status);
goto err;
}
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Yuval Shaia <yuval.shaia@oracle.com> |
|---|---|
| Date | 2017-09-26 10:00 +0200 |
| Message-ID | <utSWC-1N5-25@gated-at.bofh.it> |
| In reply to | #1739631 |
On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
> Add same changes for 'ocrdma_hw.c'
>
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 2 +-
> drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index dcb5942..b5cb69f 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -1090,7 +1090,7 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe)
> rsp = &mqe->u.rsp;
>
> if (cqe_status || ext_status) {
> - pr_err("%s() cqe_status=0x%x, ext_status=0x%x,",
> + pr_err("%s() cqe_status=0x%x, ext_status=0x%x,\n",
> __func__, cqe_status, ext_status);
> if (rsp) {
> /* This is for embedded cmds. */
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 66056f9..e528d7a 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
> if (reset) {
> status = ocrdma_mbx_rdma_stats(dev, true);
> if (status) {
> - pr_err("Failed to reset stats = %d", status);
> + pr_err("Failed to reset stats = %d\n", status);
> goto err;
> }
> }
> --
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [next] | [standalone]
| From | Leon Romanovsky <leon@kernel.org> |
|---|---|
| Date | 2017-09-26 10:50 +0200 |
| Message-ID | <utTJ1-2nL-47@gated-at.bofh.it> |
| In reply to | #1739631 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> > --- > changes in v2 : > Add same changes for 'ocrdma_hw.c' > Two notes, 1. Please send similar changes as a patchset and not as a standalone patches. 2. These patches "\n" are not needed, see my response to mlx5 patch. Thanks,
[toc] | [prev] | [next] | [standalone]
| From | Doug Ledford <dledford@redhat.com> |
|---|---|
| Date | 2017-09-27 16:30 +0200 |
| Message-ID | <uulvz-4kL-5@gated-at.bofh.it> |
| In reply to | #1739631 |
On Tue, 2017-09-26 at 12:59 +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Sorry, I replied in the wrong thread last time. It is the v2 patch
that I applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web