Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1739645

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

Show all headers | View raw

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
>                Add same changes for 'ocrdma_hw.c'
> 
>  drivers/infiniband/hw/ocrdma/ocrdma_hw.c    | 2 +-
>  drivers/infiniband/hw/ocrdma/ocrdma_stats.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> index dcb5942..b5cb69f 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> @@ -1090,7 +1090,7 @@ static int ocrdma_mbx_cmd(struct ocrdma_dev *dev, struct ocrdma_mqe *mqe)
>  		rsp = &mqe->u.rsp;
>  
>  	if (cqe_status || ext_status) {
> -		pr_err("%s() cqe_status=0x%x, ext_status=0x%x,",
> +		pr_err("%s() cqe_status=0x%x, ext_status=0x%x,\n",
>  		       __func__, cqe_status, ext_status);
>  		if (rsp) {
>  			/* This is for embedded cmds. */
> diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> index 66056f9..e528d7a 100644
> --- a/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> +++ b/drivers/infiniband/hw/ocrdma/ocrdma_stats.c
> @@ -658,7 +658,7 @@ static ssize_t ocrdma_dbgfs_ops_write(struct file *filp,
>  		if (reset) {
>  			status = ocrdma_mbx_rdma_stats(dev, true);
>  			if (status) {
> -				pr_err("Failed to reset stats = %d", status);
> +				pr_err("Failed to reset stats = %d\n", status);
>  				goto err;
>  			}
>  		}
> -- 

Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>

> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:40 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Yuval Shaia <yuval.shaia@oracle.com> - 2017-09-26 10:00 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Leon Romanovsky <leon@kernel.org> - 2017-09-26 10:50 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Doug Ledford <dledford@redhat.com> - 2017-09-27 16:30 +0200

csiph-web