Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1739718

Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines

From Leon Romanovsky <leon@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines
Date 2017-09-26 10:50 +0200
Message-ID <utTJ1-2nL-47@gated-at.bofh.it> (permalink)
References <utSDg-1Ff-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 26, 2017 at 12:59:51PM +0530, Arvind Yadav wrote:
> pr_err() messages should end with a new-line to avoid other messages
> being concatenated.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> changes in v2 :
>                Add same changes for 'ocrdma_hw.c'
>

Two notes,
1. Please send similar changes as a patchset and not as a standalone patches.
2. These patches "\n" are not needed, see my response to mlx5 patch.

Thanks,

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-26 09:40 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Yuval Shaia <yuval.shaia@oracle.com> - 2017-09-26 10:00 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Leon Romanovsky <leon@kernel.org> - 2017-09-26 10:50 +0200
  Re: [PATCH v2] IB/ocrdma: pr_err() strings should end with newlines Doug Ledford <dledford@redhat.com> - 2017-09-27 16:30 +0200

csiph-web