Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1726597 > unrolled thread
| Started by | Janani Sankara Babu <jananis37@gmail.com> |
|---|---|
| First post | 2017-09-05 12:20 +0200 |
| Last post | 2017-09-05 16:20 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Janani Sankara Babu <jananis37@gmail.com> - 2017-09-05 12:20 +0200
Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Greg KH <gregkh@linuxfoundation.org> - 2017-09-05 16:20 +0200
Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Joe Perches <joe@perches.com> - 2017-09-05 16:20 +0200
| From | Janani Sankara Babu <jananis37@gmail.com> |
|---|---|
| Date | 2017-09-05 12:20 +0200 |
| Subject | [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms |
| Message-ID | <umj7z-1oz-1@gated-at.bofh.it> |
This patch solves the following warning shown by checkpatch script
Warning: msleep < 20ms can sleep for up to 20ms
Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
index f86c9ce..78edc15 100644
--- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
+++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
@@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
break;
}
- msleep(1);
+ usleep_range(0, 1000);
}
return err;
--
1.9.1
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-09-05 16:20 +0200 |
| Message-ID | <ummRP-3Lb-3@gated-at.bofh.it> |
| In reply to | #1726597 |
On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms
>
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index f86c9ce..78edc15 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
> break;
> }
> - msleep(1);
> + usleep_range(0, 1000);
How do you know this is a valid range to sleep for?
[toc] | [prev] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-09-05 16:20 +0200 |
| Message-ID | <ummRP-3Lb-5@gated-at.bofh.it> |
| In reply to | #1726597 |
On Tue, 2017-09-05 at 15:36 +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
[]
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
> DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
> break;
> }
> - msleep(1);
> + usleep_range(0, 1000);
No, that would sleep a random time up to 1 ms.
usleep_range(1000, 2000) might be OK but please
check the value passed as delay_ms.
It's only used as LPS_LEAVE_TIMEOUT_MS (100 here)
so it seems just fine to keep using msleep.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web