Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1726769

Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms
Date 2017-09-05 16:20 +0200
Message-ID <ummRP-3Lb-3@gated-at.bofh.it> (permalink)
References <umj7z-1oz-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Sep 05, 2017 at 03:36:41PM +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms 
> 
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
>  drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> index f86c9ce..78edc15 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
>  			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
>  			break;
>  		}
> -		msleep(1);
> +		usleep_range(0, 1000);

How do you know this is a valid range to sleep for?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Janani Sankara Babu <jananis37@gmail.com> - 2017-09-05 12:20 +0200
  Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Greg KH <gregkh@linuxfoundation.org> - 2017-09-05 16:20 +0200
  Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Joe Perches <joe@perches.com> - 2017-09-05 16:20 +0200

csiph-web