Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms
Date	2017-09-05 16:20 +0200
Message-ID	<ummRP-3Lb-5@gated-at.bofh.it> (permalink)
References	<umj7z-1oz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 2017-09-05 at 15:36 +0530, Janani Sankara Babu wrote:
> This patch solves the following warning shown by checkpatch script
> Warning: msleep < 20ms can sleep for up to 20ms 
[]
> diff --git a/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c b/drivers/staging/rtl8188eu/core/rtw_pwrctrl.c
[]
> @@ -436,7 +436,7 @@ s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms)
>  			DBG_88E("%s: Wait for FW LPS leave more than %u ms!!!\n", __func__, delay_ms);
>  			break;
>  		}
> -		msleep(1);
> +		usleep_range(0, 1000);

No, that would sleep a random time up to 1 ms.

usleep_range(1000, 2000) might be OK but please
check the value passed as delay_ms.

It's only used as LPS_LEAVE_TIMEOUT_MS (100 here)
so it seems just fine to keep using msleep.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Janani Sankara Babu <jananis37@gmail.com> - 2017-09-05 12:20 +0200
  Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Greg KH <gregkh@linuxfoundation.org> - 2017-09-05 16:20 +0200
  Re: [PATCH] staging:rtl8188eu Fix msleep < 20ms can sleep upto 20ms Joe Perches <joe@perches.com> - 2017-09-05 16:20 +0200

csiph-web