Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1711278 > unrolled thread
| Started by | Nick Desaulniers <ndesaulniers@google.com> |
|---|---|
| First post | 2017-08-14 19:40 +0200 |
| Last post | 2017-08-24 19:00 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-14 19:40 +0200
Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-24 18:30 +0200
Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Pablo Neira Ayuso <pablo@netfilter.org> - 2017-08-24 19:00 +0200
| From | Nick Desaulniers <ndesaulniers@google.com> |
|---|---|
| Date | 2017-08-14 19:40 +0200 |
| Subject | Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning |
| Message-ID | <uervk-72Y-23@gated-at.bofh.it> |
Minor nit for the commit message that can get fixed up when being merged: On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers <ndesaulniers@google.com> wrote: > if (x) > return > ... > > rather than: > > if (!x == 0) should remove the `!`, ex: if (x == 0) > ... > else > return -- Thanks, ~Nick Desaulniers
[toc] | [next] | [standalone]
| From | Nick Desaulniers <ndesaulniers@google.com> |
|---|---|
| Date | 2017-08-24 18:30 +0200 |
| Message-ID | <ui3b3-tc-1@gated-at.bofh.it> |
| In reply to | #1711278 |
bumping for review (resending, had gmail set to html mode) On Mon, Aug 14, 2017 at 10:36 AM, Nick Desaulniers <ndesaulniers@google.com> wrote: > Minor nit for the commit message that can get fixed up when being merged: > > On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > >> if (x) >> return >> ... >> >> rather than: >> >> if (!x == 0) > > should remove the `!`, ex: > > if (x == 0) > >> ... >> else >> return > > -- > Thanks, > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers
[toc] | [prev] | [next] | [standalone]
| From | Pablo Neira Ayuso <pablo@netfilter.org> |
|---|---|
| Date | 2017-08-24 19:00 +0200 |
| Subject | Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning |
| Message-ID | <ui3E6-Db-27@gated-at.bofh.it> |
| In reply to | #1711278 |
On Mon, Aug 14, 2017 at 10:36:03AM -0700, Nick Desaulniers wrote: > Minor nit for the commit message that can get fixed up when being merged: > > On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > > > if (x) > > return > > ... > > > > rather than: > > > > if (!x == 0) > > should remove the `!`, ex: > > if (x == 0) Amended this here, and applied. Thanks!
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web