Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1719383
| From | Nick Desaulniers <ndesaulniers@google.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning |
| Date | 2017-08-24 18:30 +0200 |
| Message-ID | <ui3b3-tc-1@gated-at.bofh.it> (permalink) |
| References | <udmel-6sy-7@gated-at.bofh.it> <udmHn-6RA-9@gated-at.bofh.it> <uervk-72Y-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
bumping for review (resending, had gmail set to html mode) On Mon, Aug 14, 2017 at 10:36 AM, Nick Desaulniers <ndesaulniers@google.com> wrote: > Minor nit for the commit message that can get fixed up when being merged: > > On Fri, Aug 11, 2017 at 11:16 AM, Nick Desaulniers > <ndesaulniers@google.com> wrote: > >> if (x) >> return >> ... >> >> rather than: >> >> if (!x == 0) > > should remove the `!`, ex: > > if (x == 0) > >> ... >> else >> return > > -- > Thanks, > ~Nick Desaulniers -- Thanks, ~Nick Desaulniers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-14 19:40 +0200 Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Nick Desaulniers <ndesaulniers@google.com> - 2017-08-24 18:30 +0200 Re: [PATCH v2] netfilter: nf_nat_h323: fix logical-not-parentheses warning Pablo Neira Ayuso <pablo@netfilter.org> - 2017-08-24 19:00 +0200
csiph-web