Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706771 > unrolled thread

[PATCH 0/3] constify staging usb_device_id

Started byArvind Yadav <arvind.yadav.cs@gmail.com>
First post2017-08-08 19:30 +0200
Last post2017-08-09 11:50 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/3] constify staging usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
    [PATCH 2/3] staging: rtl8188eu: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
    [PATCH 3/3] staging: rtl8712: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
    [PATCH 1/3] staging: most: usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
      Re: [PATCH 1/3] staging: most: usb: constify usb_device_id Christian Gromm <christian.gromm@microchip.com> - 2017-08-09 11:50 +0200

#1706771 — [PATCH 0/3] constify staging usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-08 19:30 +0200
Subject[PATCH 0/3] constify staging usb_device_id
Message-ID<ucgul-37R-5@gated-at.bofh.it>
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Arvind Yadav (3):
  [PATCH 1/3] staging: most: usb: constify usb_device_id
  [PATCH 2/3] staging: rtl8188eu: constify usb_device_id
  [PATCH 3/3] staging: rtl8712: constify usb_device_id

 drivers/staging/most/hdm-usb/hdm_usb.c      | 2 +-
 drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
 drivers/staging/rtl8712/usb_intf.c          | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.7.4

[toc] | [next] | [standalone]

#1706772 — [PATCH 2/3] staging: rtl8188eu: constify usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-08 19:30 +0200
Subject[PATCH 2/3] staging: rtl8188eu: constify usb_device_id
Message-ID<ucgul-37R-13@gated-at.bofh.it>
In reply to#1706771
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
index 963235f..2ef71c3 100644
--- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c
+++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c
@@ -32,7 +32,7 @@
 #define USB_VENDER_ID_REALTEK		0x0bda
 
 /* DID_USB_v916_20130116 */
-static struct usb_device_id rtw_usb_id_tbl[] = {
+static const struct usb_device_id rtw_usb_id_tbl[] = {
 	/*=== Realtek demoboard ===*/
 	{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x8179)}, /* 8188EUS */
 	{USB_DEVICE(USB_VENDER_ID_REALTEK, 0x0179)}, /* 8188ETV */
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1706773 — [PATCH 3/3] staging: rtl8712: constify usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-08 19:30 +0200
Subject[PATCH 3/3] staging: rtl8712: constify usb_device_id
Message-ID<ucgul-37R-17@gated-at.bofh.it>
In reply to#1706771
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/staging/rtl8712/usb_intf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/usb_intf.c b/drivers/staging/rtl8712/usb_intf.c
index 897d462..b3e266b 100644
--- a/drivers/staging/rtl8712/usb_intf.c
+++ b/drivers/staging/rtl8712/usb_intf.c
@@ -47,7 +47,7 @@ static int r871xu_drv_init(struct usb_interface *pusb_intf,
 
 static void r871xu_dev_remove(struct usb_interface *pusb_intf);
 
-static struct usb_device_id rtl871x_usb_id_tbl[] = {
+static const struct usb_device_id rtl871x_usb_id_tbl[] = {
 
 /* RTL8188SU */
 	/* Realtek */
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1706775 — [PATCH 1/3] staging: most: usb: constify usb_device_id

FromArvind Yadav <arvind.yadav.cs@gmail.com>
Date2017-08-08 19:30 +0200
Subject[PATCH 1/3] staging: most: usb: constify usb_device_id
Message-ID<ucgum-37R-27@gated-at.bofh.it>
In reply to#1706771
usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
index d0f68cb..a9c3785 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops = {
 /**
  * usb_device_id - ID table for HCD device probing
  */
-static struct usb_device_id usbid[] = {
+static const struct usb_device_id usbid[] = {
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },
-- 
2.7.4

[toc] | [prev] | [next] | [standalone]

#1707199 — Re: [PATCH 1/3] staging: most: usb: constify usb_device_id

FromChristian Gromm <christian.gromm@microchip.com>
Date2017-08-09 11:50 +0200
SubjectRe: [PATCH 1/3] staging: most: usb: constify usb_device_id
Message-ID<ucvMJ-5na-7@gated-at.bofh.it>
In reply to#1706775
On Tue, 8 Aug 2017 22:53:13 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
> b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops
> = { /**
>   * usb_device_id - ID table for HCD device probing
>   */
> -static struct usb_device_id usbid[] = {
> +static const struct usb_device_id usbid[] = {
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },



-- 
thanks,
Chris


Christian Gromm
Principal Software Engineer

Microchip Technology Germany II GmbH & Co. KG
Emmy-Noether-Straße 14
76131 Karlsruhe | Germany

Tel: +49 721 62537 466 | Fax: +49 721 62537 119
christian.gromm@microchip.com | www.microchip.com

Firmensitz: Ismaning
Registergericht: Amtsgericht München, HRA 98692

Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH
mit Sitz in Ismaning Registergericht: München, HRB 197 653
Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert
Siedhoff

Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht
durch andere als die ursprünglich genannten Adressaten genutzt, kopiert
oder weitergeleitet werden. This e-mail may contain confidential
information and should not be used, copied or disclosed by anyone who
is not the original intended recipient.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web