Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1706775

[PATCH 1/3] staging: most: usb: constify usb_device_id

Show all headers | View raw

usb_device_id are not supposed to change at runtime. All functions
working with usb_device_id provided by <linux/usb.h> work with
const usb_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c b/drivers/staging/most/hdm-usb/hdm_usb.c
index d0f68cb..a9c3785 100644
--- a/drivers/staging/most/hdm-usb/hdm_usb.c
+++ b/drivers/staging/most/hdm-usb/hdm_usb.c
@@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops = {
 /**
  * usb_device_id - ID table for HCD device probing
  */
-static struct usb_device_id usbid[] = {
+static const struct usb_device_id usbid[] = {
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
 	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] constify staging usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 2/3] staging: rtl8188eu: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 3/3] staging: rtl8712: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 1/3] staging: most: usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
    Re: [PATCH 1/3] staging: most: usb: constify usb_device_id Christian Gromm <christian.gromm@microchip.com> - 2017-08-09 11:50 +0200

csiph-web