Re: [PATCH 1/3] staging: most: usb: constify usb_device_id

From	Christian Gromm <christian.gromm@microchip.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] staging: most: usb: constify usb_device_id
Date	2017-08-09 11:50 +0200
Message-ID	<ucvMJ-5na-7@gated-at.bofh.it> (permalink)
References	<ucgul-37R-5@gated-at.bofh.it> <ucgum-37R-27@gated-at.bofh.it>
Organization	Microchip Technology Germany - AIS Engineering

Show all headers | View raw

On Tue, 8 Aug 2017 22:53:13 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> usb_device_id are not supposed to change at runtime. All functions
> working with usb_device_id provided by <linux/usb.h> work with
> const usb_device_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Christian Gromm <christian.gromm@microchip.com>
> ---
>  drivers/staging/most/hdm-usb/hdm_usb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/most/hdm-usb/hdm_usb.c
> b/drivers/staging/most/hdm-usb/hdm_usb.c index d0f68cb..a9c3785 100644
> --- a/drivers/staging/most/hdm-usb/hdm_usb.c
> +++ b/drivers/staging/most/hdm-usb/hdm_usb.c
> @@ -832,7 +832,7 @@ static const struct file_operations hdm_usb_fops
> = { /**
>   * usb_device_id - ID table for HCD device probing
>   */
> -static struct usb_device_id usbid[] = {
> +static const struct usb_device_id usbid[] = {
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_BRDG), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81118), },
>  	{ USB_DEVICE(USB_VENDOR_ID_SMSC, USB_DEV_ID_OS81119), },



-- 
thanks,
Chris


Christian Gromm
Principal Software Engineer

Microchip Technology Germany II GmbH & Co. KG
Emmy-Noether-Straße 14
76131 Karlsruhe | Germany

Tel: +49 721 62537 466 | Fax: +49 721 62537 119
christian.gromm@microchip.com | www.microchip.com

Firmensitz: Ismaning
Registergericht: Amtsgericht München, HRA 98692

Persönlich haftende Gesellschafterin: Microchip Technology Germany GmbH
mit Sitz in Ismaning Registergericht: München, HRB 197 653
Geschäftsführer: Mohammed Nawaz Sharif, James Eric Bjornholt, Norbert
Siedhoff

Diese E-Mail kann vertrauliche Informationen enthalten. Sie darf nicht
durch andere als die ursprünglich genannten Adressaten genutzt, kopiert
oder weitergeleitet werden. This e-mail may contain confidential
information and should not be used, copied or disclosed by anyone who
is not the original intended recipient.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/3] constify staging usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 2/3] staging: rtl8188eu: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 3/3] staging: rtl8712: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
  [PATCH 1/3] staging: most: usb: constify usb_device_id Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-08-08 19:30 +0200
    Re: [PATCH 1/3] staging: most: usb: constify usb_device_id Christian Gromm <christian.gromm@microchip.com> - 2017-08-09 11:50 +0200

csiph-web