Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1705459 > unrolled thread
| Started by | Fabio Estevam <festevam@gmail.com> |
|---|---|
| First post | 2017-08-07 14:50 +0200 |
| Last post | 2017-08-08 03:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios Fabio Estevam <festevam@gmail.com> - 2017-08-07 14:50 +0200
RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios Peng Fan <peng.fan@nxp.com> - 2017-08-08 03:20 +0200
| From | Fabio Estevam <festevam@gmail.com> |
|---|---|
| Date | 2017-08-07 14:50 +0200 |
| Subject | Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios |
| Message-ID | <ubPDQ-8gK-9@gated-at.bofh.it> |
On Mon, Aug 7, 2017 at 9:27 AM, Peng Fan <peng.fan@nxp.com> wrote:
> + chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
> + if (IS_ERR(chip->enable_gpio)) {
> + dev_dbg(&spi->dev, "No enable-gpios property\n");
> + chip->enable_gpio = NULL;
Also, the error handling here is not correct as it will never
propagate EPROBE_DEFER.
I will submit my version of the patch if you don't mind.
[toc] | [next] | [standalone]
| From | Peng Fan <peng.fan@nxp.com> |
|---|---|
| Date | 2017-08-08 03:20 +0200 |
| Message-ID | <uc1lD-pD-3@gated-at.bofh.it> |
| In reply to | #1705459 |
> > + chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > + if (IS_ERR(chip->enable_gpio)) {
> > + dev_dbg(&spi->dev, "No enable-gpios property\n");
> > + chip->enable_gpio = NULL;
>
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
>
> I will submit my version of the patch if you don't mind.
That's ok if you have a better patch.
Regards,
Peng.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web