Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios

From	Fabio Estevam <festevam@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios
Date	2017-08-07 14:50 +0200
Message-ID	<ubPDQ-8gK-9@gated-at.bofh.it> (permalink)
References	<ubPub-8bG-29@gated-at.bofh.it> <ubPub-8bG-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Aug 7, 2017 at 9:27 AM, Peng Fan <peng.fan@nxp.com> wrote:

> +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable", GPIOD_OUT_LOW);
> +       if (IS_ERR(chip->enable_gpio)) {
> +               dev_dbg(&spi->dev, "No enable-gpios property\n");
> +               chip->enable_gpio = NULL;

Also, the error handling here is not correct as it will never
propagate EPROBE_DEFER.

I will submit my version of the patch if you don't mind.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios Fabio Estevam <festevam@gmail.com> - 2017-08-07 14:50 +0200
  RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios Peng Fan <peng.fan@nxp.com> - 2017-08-08 03:20 +0200

csiph-web