RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios

From	Peng Fan <peng.fan@nxp.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios
Date	2017-08-08 03:20 +0200
Message-ID	<uc1lD-pD-3@gated-at.bofh.it> (permalink)
References	<ubPub-8bG-29@gated-at.bofh.it> <ubPub-8bG-31@gated-at.bofh.it> <ubPDQ-8gK-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > +       if (IS_ERR(chip->enable_gpio)) {
> > +               dev_dbg(&spi->dev, "No enable-gpios property\n");
> > +               chip->enable_gpio = NULL;
> 
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
> 
> I will submit my version of the patch if you don't mind.

That's ok if you have a better patch.

Regards,
Peng.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] gpio: 74x164: handling enable-gpios Fabio Estevam <festevam@gmail.com> - 2017-08-07 14:50 +0200
  RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios Peng Fan <peng.fan@nxp.com> - 2017-08-08 03:20 +0200

csiph-web