Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616890 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-04-05 14:40 +0200 |
| Last post | 2017-04-06 22:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] qed: fix missing break in OOO_LB_TC case Colin King <colin.king@canonical.com> - 2017-04-05 14:40 +0200
RE: [PATCH] qed: fix missing break in OOO_LB_TC case "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-04-05 14:50 +0200
Re: [PATCH] qed: fix missing break in OOO_LB_TC case David Miller <davem@davemloft.net> - 2017-04-06 22:30 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-04-05 14:40 +0200 |
| Subject | [PATCH] qed: fix missing break in OOO_LB_TC case |
| Message-ID | <tsSoa-2BK-15@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.
Detected by CoverityScan, CID#1424402 ("Missing break in switch")
Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 708c601e8ccf..13e65d446ab3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
break;
case OOO_LB_TC:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+ break;
default:
pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
break;
--
2.11.0
[toc] | [next] | [standalone]
| From | "Mintz, Yuval" <Yuval.Mintz@cavium.com> |
|---|---|
| Date | 2017-04-05 14:50 +0200 |
| Message-ID | <tsSxQ-2F7-17@gated-at.bofh.it> |
| In reply to | #1616890 |
> There seems to be a missing break on the OOO_LB_TC case, pq_id is being
> assigned and then re-assigned on the fall through default case and that
> seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Thanks!
Acked-by: Yuval Mintz <Yuval.Mintz@cavium.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-04-06 22:30 +0200 |
| Message-ID | <ttmcx-5J2-11@gated-at.bofh.it> |
| In reply to | #1616890 |
From: Colin King <colin.king@canonical.com>
Date: Wed, 5 Apr 2017 13:35:44 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There seems to be a missing break on the OOO_LB_TC case, pq_id
> is being assigned and then re-assigned on the fall through default
> case and that seems suspect.
>
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
>
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web