[PATCH] qed: fix missing break in OOO_LB_TC case

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH] qed: fix missing break in OOO_LB_TC case
Date	2017-04-05 14:40 +0200
Message-ID	<tsSoa-2BK-15@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

There seems to be a missing break on the OOO_LB_TC case, pq_id
is being assigned and then re-assigned on the fall through default
case and that seems suspect.

Detected by CoverityScan, CID#1424402 ("Missing break in switch")

Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/net/ethernet/qlogic/qed/qed_ll2.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_ll2.c b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
index 708c601e8ccf..13e65d446ab3 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_ll2.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_ll2.c
@@ -1132,6 +1132,7 @@ static int qed_sp_ll2_tx_queue_start(struct qed_hwfn *p_hwfn,
 		break;
 	case OOO_LB_TC:
 		pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OOO);
+		break;
 	default:
 		pq_id = qed_get_cm_pq_idx(p_hwfn, PQ_FLAGS_OFLD);
 		break;
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] qed: fix missing break in OOO_LB_TC case Colin King <colin.king@canonical.com> - 2017-04-05 14:40 +0200
  RE: [PATCH] qed: fix missing break in OOO_LB_TC case "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-04-05 14:50 +0200
  Re: [PATCH] qed: fix missing break in OOO_LB_TC case David Miller <davem@davemloft.net> - 2017-04-06 22:30 +0200

csiph-web