Re: [PATCH] qed: fix missing break in OOO_LB_TC case

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] qed: fix missing break in OOO_LB_TC case
Date	2017-04-06 22:30 +0200
Message-ID	<ttmcx-5J2-11@gated-at.bofh.it> (permalink)
References	<tsSoa-2BK-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Wed,  5 Apr 2017 13:35:44 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> There seems to be a missing break on the OOO_LB_TC case, pq_id
> is being assigned and then re-assigned on the fall through default
> case and that seems suspect.
> 
> Detected by CoverityScan, CID#1424402 ("Missing break in switch")
> 
> Fixes: b5a9ee7cf3be1 ("qed: Revise QM cofiguration")
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] qed: fix missing break in OOO_LB_TC case Colin King <colin.king@canonical.com> - 2017-04-05 14:40 +0200
  RE: [PATCH] qed: fix missing break in OOO_LB_TC case "Mintz, Yuval" <Yuval.Mintz@cavium.com> - 2017-04-05 14:50 +0200
  Re: [PATCH] qed: fix missing break in OOO_LB_TC case David Miller <davem@davemloft.net> - 2017-04-06 22:30 +0200

csiph-web