Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1606114 > unrolled thread

[PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

Started bySebastian Reichel <sre@kernel.org>
First post2017-03-22 01:20 +0100
Last post2017-03-23 16:00 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-22 01:20 +0100
    Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Pavel Machek <pavel@ucw.cz> - 2017-03-22 10:30 +0100
      Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-22 17:00 +0100
        Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Sebastian Reichel <sre@kernel.org> - 2017-03-23 02:10 +0100
          Re: [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies Tony Lindgren <tony@atomide.com> - 2017-03-23 16:00 +0100

#1606114 — [PATCHv2 1/2] mfd: cpcap: Add missing include dependencies

FromSebastian Reichel <sre@kernel.org>
Date2017-03-22 01:20 +0100
Subject[PATCHv2 1/2] mfd: cpcap: Add missing include dependencies
Message-ID<tnCal-2uo-5@gated-at.bofh.it>
This fixes compilation for files, that try to include the
cpcap header in alphabetically sorted #include lists.

Signed-off-by: Sebastian Reichel <sre@kernel.org>
---
This patch is new, since PATCHv1 did not order the includes
in the led driver alphabetically.
---
 include/linux/mfd/motorola-cpcap.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
index 7629e0d24d26..b8916953a537 100644
--- a/include/linux/mfd/motorola-cpcap.h
+++ b/include/linux/mfd/motorola-cpcap.h
@@ -14,6 +14,9 @@
  * published by the Free Software Foundation.
  */
 
+#include <linux/device.h>
+#include <linux/regmap.h>
+
 #define CPCAP_VENDOR_ST		0
 #define CPCAP_VENDOR_TI		1
 
-- 
2.11.0

[toc] | [next] | [standalone]

#1606300

FromPavel Machek <pavel@ucw.cz>
Date2017-03-22 10:30 +0100
Message-ID<tnKKC-aT-5@gated-at.bofh.it>
In reply to#1606114

[Multipart message — attachments visible in raw view] — view raw

On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> This fixes compilation for files, that try to include the
> cpcap header in alphabetically sorted #include lists.
> 
> Signed-off-by: Sebastian Reichel <sre@kernel.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

> ---
> This patch is new, since PATCHv1 did not order the includes
> in the led driver alphabetically.
> ---
>  include/linux/mfd/motorola-cpcap.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
> index 7629e0d24d26..b8916953a537 100644
> --- a/include/linux/mfd/motorola-cpcap.h
> +++ b/include/linux/mfd/motorola-cpcap.h
> @@ -14,6 +14,9 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#include <linux/device.h>
> +#include <linux/regmap.h>
> +
>  #define CPCAP_VENDOR_ST		0
>  #define CPCAP_VENDOR_TI		1
>  

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1606694

FromTony Lindgren <tony@atomide.com>
Date2017-03-22 17:00 +0100
Message-ID<tnQQ3-4OP-57@gated-at.bofh.it>
In reply to#1606300
* Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > This fixes compilation for files, that try to include the
> > cpcap header in alphabetically sorted #include lists.
> > 
> > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Hmm I wonder why I never ran into this so far. No objections
to the patch though if it fixes the issue with all the necessary
headers included.

Regards,

Tony


> > ---
> > This patch is new, since PATCHv1 did not order the includes
> > in the led driver alphabetically.
> > ---
> >  include/linux/mfd/motorola-cpcap.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/include/linux/mfd/motorola-cpcap.h b/include/linux/mfd/motorola-cpcap.h
> > index 7629e0d24d26..b8916953a537 100644
> > --- a/include/linux/mfd/motorola-cpcap.h
> > +++ b/include/linux/mfd/motorola-cpcap.h
> > @@ -14,6 +14,9 @@
> >   * published by the Free Software Foundation.
> >   */
> >  
> > +#include <linux/device.h>
> > +#include <linux/regmap.h>
> > +
> >  #define CPCAP_VENDOR_ST		0
> >  #define CPCAP_VENDOR_TI		1
> >  
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [prev] | [next] | [standalone]

#1607104

FromSebastian Reichel <sre@kernel.org>
Date2017-03-23 02:10 +0100
Message-ID<tnZqh-36m-7@gated-at.bofh.it>
In reply to#1606694

[Multipart message — attachments visible in raw view] — view raw

Hi,

On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> * Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > This fixes compilation for files, that try to include the
> > > cpcap header in alphabetically sorted #include lists.
> > > 
> > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > 
> > Acked-by: Pavel Machek <pavel@ucw.cz>
> 
> Hmm I wonder why I never ran into this so far. No objections
> to the patch though if it fixes the issue with all the necessary
> headers included.

Because you usually sort includes differently moving headers
from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
device.h will already be included when the compiler includes
motorola-cpcap.h.

-- Sebastian

[toc] | [prev] | [next] | [standalone]

#1607569

FromTony Lindgren <tony@atomide.com>
Date2017-03-23 16:00 +0100
Message-ID<tocnw-3Ak-25@gated-at.bofh.it>
In reply to#1607104
* Sebastian Reichel <sre@kernel.org> [170322 18:02]:
> Hi,
> 
> On Wed, Mar 22, 2017 at 08:57:16AM -0700, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170322 02:29]:
> > > On Wed 2017-03-22 01:09:11, Sebastian Reichel wrote:
> > > > This fixes compilation for files, that try to include the
> > > > cpcap header in alphabetically sorted #include lists.
> > > > 
> > > > Signed-off-by: Sebastian Reichel <sre@kernel.org>
> > > 
> > > Acked-by: Pavel Machek <pavel@ucw.cz>
> > 
> > Hmm I wonder why I never ran into this so far. No objections
> > to the patch though if it fixes the issue with all the necessary
> > headers included.
> 
> Because you usually sort includes differently moving headers
> from linux/subdir/XYZ after linux/XYZ. That way regmap.h and
> device.h will already be included when the compiler includes
> motorola-cpcap.h.

Ah OK yeah I do that usually. Your patch seems OK to me:

Acked-by: Tony Lindgren <tony@atomide.com>

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web