Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1594603 > unrolled thread
| Started by | David Miller <davem@davemloft.net> |
|---|---|
| First post | 2017-03-07 21:20 +0100 |
| Last post | 2017-03-08 00:50 +0100 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error David Miller <davem@davemloft.net> - 2017-03-07 21:20 +0100
Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 21:40 +0100
[PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 22:00 +0100
Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation error David Miller <davem@davemloft.net> - 2017-03-09 22:30 +0100
Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error David Miller <davem@davemloft.net> - 2017-03-08 00:50 +0100
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-03-07 21:20 +0100 |
| Subject | Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error |
| Message-ID | <titKp-4c4-3@gated-at.bofh.it> |
From: "Dmitry V. Levin" <ldv@altlinux.org> Date: Tue, 28 Feb 2017 04:39:30 +0300 > Replace MAX_ADDR_LEN with its numeric value to fix the following > linux/packet_diag.h userspace compilation error: > > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) > __u8 pdmc_addr[MAX_ADDR_LEN]; > > This is not the first case in the UAPI where the numeric value > of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same, > and there are no UAPI headers besides these two that use MAX_ADDR_LEN. > > The alternative fix would be to include <linux/netdevice.h> which > pulls in other headers and a lot of definitions with them. > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> If if_link.h includes netdevice.h properly, let's try to do the same here as well. Thanks.
[toc] | [next] | [standalone]
| From | "Dmitry V. Levin" <ldv@altlinux.org> |
|---|---|
| Date | 2017-03-07 21:40 +0100 |
| Subject | Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error |
| Message-ID | <tiu3L-4n9-5@gated-at.bofh.it> |
| In reply to | #1594603 |
On Tue, Mar 07, 2017 at 12:16:49PM -0800, David Miller wrote: > From: "Dmitry V. Levin" <ldv@altlinux.org> > Date: Tue, 28 Feb 2017 04:39:30 +0300 > > > Replace MAX_ADDR_LEN with its numeric value to fix the following > > linux/packet_diag.h userspace compilation error: > > > > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) > > __u8 pdmc_addr[MAX_ADDR_LEN]; > > > > This is not the first case in the UAPI where the numeric value > > of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same, > > and there are no UAPI headers besides these two that use MAX_ADDR_LEN. > > > > The alternative fix would be to include <linux/netdevice.h> which > > pulls in other headers and a lot of definitions with them. > > > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > > If if_link.h includes netdevice.h properly, let's try to do the same here as well. Sorry if my words weren't clear enough: no, if_link.h doesn't include netdevice.h, it uses the _numeric_ value instead: $ grep MAX_ADDR_LEN include/uapi/linux/if_link.h __u8 mac[32]; /* MAX_ADDR_LEN */ -- ldv
[toc] | [prev] | [next] | [standalone]
| From | "Dmitry V. Levin" <ldv@altlinux.org> |
|---|---|
| Date | 2017-03-07 22:00 +0100 |
| Subject | [PATCH] uapi: fix linux/packet_diag.h userspace compilation error |
| Message-ID | <tiun8-4vP-9@gated-at.bofh.it> |
| In reply to | #1594617 |
Replace MAX_ADDR_LEN with its numeric value to fix the following
linux/packet_diag.h userspace compilation error:
/usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function)
__u8 pdmc_addr[MAX_ADDR_LEN];
This is not the first case in the UAPI where the numeric value
of MAX_ADDR_LEN is used instead of symbolic one, uapi/linux/if_link.h
already does the same:
$ grep MAX_ADDR_LEN include/uapi/linux/if_link.h
__u8 mac[32]; /* MAX_ADDR_LEN */
There are no UAPI headers besides these two that use MAX_ADDR_LEN.
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
Acked-by: Pavel Emelyanov <xemul@virtuozzo.com>
---
include/uapi/linux/packet_diag.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/packet_diag.h b/include/uapi/linux/packet_diag.h
index d08c63f..0c5d5dd 100644
--- a/include/uapi/linux/packet_diag.h
+++ b/include/uapi/linux/packet_diag.h
@@ -64,7 +64,7 @@ struct packet_diag_mclist {
__u32 pdmc_count;
__u16 pdmc_type;
__u16 pdmc_alen;
- __u8 pdmc_addr[MAX_ADDR_LEN];
+ __u8 pdmc_addr[32]; /* MAX_ADDR_LEN */
};
struct packet_diag_ring {
--
ldv
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-03-09 22:30 +0100 |
| Subject | Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation error |
| Message-ID | <tjdNf-2mg-13@gated-at.bofh.it> |
| In reply to | #1594637 |
From: "Dmitry V. Levin" <ldv@altlinux.org> Date: Tue, 7 Mar 2017 23:50:50 +0300 > Replace MAX_ADDR_LEN with its numeric value to fix the following > linux/packet_diag.h userspace compilation error: > > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) > __u8 pdmc_addr[MAX_ADDR_LEN]; > > This is not the first case in the UAPI where the numeric value > of MAX_ADDR_LEN is used instead of symbolic one, uapi/linux/if_link.h > already does the same: > > $ grep MAX_ADDR_LEN include/uapi/linux/if_link.h > __u8 mac[32]; /* MAX_ADDR_LEN */ > > There are no UAPI headers besides these two that use MAX_ADDR_LEN. > > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> > Acked-by: Pavel Emelyanov <xemul@virtuozzo.com> Applied and queued up for -stable.
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-03-08 00:50 +0100 |
| Message-ID | <tiun8-4vP-11@gated-at.bofh.it> |
| In reply to | #1594617 |
From: "Dmitry V. Levin" <ldv@altlinux.org> Date: Tue, 7 Mar 2017 23:28:02 +0300 > On Tue, Mar 07, 2017 at 12:16:49PM -0800, David Miller wrote: >> From: "Dmitry V. Levin" <ldv@altlinux.org> >> Date: Tue, 28 Feb 2017 04:39:30 +0300 >> >> > Replace MAX_ADDR_LEN with its numeric value to fix the following >> > linux/packet_diag.h userspace compilation error: >> > >> > /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function) >> > __u8 pdmc_addr[MAX_ADDR_LEN]; >> > >> > This is not the first case in the UAPI where the numeric value >> > of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same, >> > and there are no UAPI headers besides these two that use MAX_ADDR_LEN. >> > >> > The alternative fix would be to include <linux/netdevice.h> which >> > pulls in other headers and a lot of definitions with them. >> > >> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org> >> >> If if_link.h includes netdevice.h properly, let's try to do the same here as well. > > Sorry if my words weren't clear enough: no, if_link.h doesn't include > netdevice.h, it uses the _numeric_ value instead: > > $ grep MAX_ADDR_LEN include/uapi/linux/if_link.h > __u8 mac[32]; /* MAX_ADDR_LEN */ Ok then we might as well do the same thing here, please resubmit this patch formally. Thanks.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web