Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1596395

Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation error

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation error
Date 2017-03-09 22:30 +0100
Message-ID <tjdNf-2mg-13@gated-at.bofh.it> (permalink)
References <tiu3L-4n9-5@gated-at.bofh.it> <tiun8-4vP-11@gated-at.bofh.it> <tiun8-4vP-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Tue, 7 Mar 2017 23:50:50 +0300

> Replace MAX_ADDR_LEN with its numeric value to fix the following
> linux/packet_diag.h userspace compilation error:
> 
> /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function)
>   __u8 pdmc_addr[MAX_ADDR_LEN];
> 
> This is not the first case in the UAPI where the numeric value
> of MAX_ADDR_LEN is used instead of symbolic one, uapi/linux/if_link.h
> already does the same:
> 
> $ grep MAX_ADDR_LEN include/uapi/linux/if_link.h 
> 	__u8 mac[32]; /* MAX_ADDR_LEN */
> 
> There are no UAPI headers besides these two that use MAX_ADDR_LEN.
> 
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> Acked-by: Pavel Emelyanov <xemul@virtuozzo.com>

Applied and queued up for -stable.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace  compilation error David Miller <davem@davemloft.net> - 2017-03-07 21:20 +0100
  Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 21:40 +0100
    [PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 22:00 +0100
      Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation  error David Miller <davem@davemloft.net> - 2017-03-09 22:30 +0100
    Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace  compilation error David Miller <davem@davemloft.net> - 2017-03-08 00:50 +0100

csiph-web