Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error
Date	2017-03-07 21:20 +0100
Message-ID	<titKp-4c4-3@gated-at.bofh.it> (permalink)
References	<tfF5n-5HS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Dmitry V. Levin" <ldv@altlinux.org>
Date: Tue, 28 Feb 2017 04:39:30 +0300

> Replace MAX_ADDR_LEN with its numeric value to fix the following
> linux/packet_diag.h userspace compilation error:
> 
> /usr/include/linux/packet_diag.h:67:17: error: 'MAX_ADDR_LEN' undeclared here (not in a function)
>   __u8 pdmc_addr[MAX_ADDR_LEN];
> 
> This is not the first case in the UAPI where the numeric value
> of MAX_ADDR_LEN is used, uapi/linux/if_link.h already does the same,
> and there are no UAPI headers besides these two that use MAX_ADDR_LEN.
> 
> The alternative fix would be to include <linux/netdevice.h> which
> pulls in other headers and a lot of definitions with them.
> 
> Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>

If if_link.h includes netdevice.h properly, let's try to do the same here as well.

Thanks.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace  compilation error David Miller <davem@davemloft.net> - 2017-03-07 21:20 +0100
  Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 21:40 +0100
    [PATCH] uapi: fix linux/packet_diag.h userspace compilation error "Dmitry V. Levin" <ldv@altlinux.org> - 2017-03-07 22:00 +0100
      Re: [PATCH] uapi: fix linux/packet_diag.h userspace compilation  error David Miller <davem@davemloft.net> - 2017-03-09 22:30 +0100
    Re: [RFC PATCH] uapi: fix linux/packet_diag.h userspace  compilation error David Miller <davem@davemloft.net> - 2017-03-08 00:50 +0100

csiph-web