Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1589735 > unrolled thread
| Started by | Alexander Kapshuk <alexander.kapshuk@gmail.com> |
|---|---|
| First post | 2017-02-28 21:10 +0100 |
| Last post | 2017-03-04 10:10 +0100 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 21:10 +0100
Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Joe Perches <joe@perches.com> - 2017-02-28 21:40 +0100
Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-02-28 22:40 +0100
Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. Greg KH <gregkh@linuxfoundation.org> - 2017-03-01 11:00 +0100
[PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations Alexander Kapshuk <alexander.kapshuk@gmail.com> - 2017-03-04 10:10 +0100
| From | Alexander Kapshuk <alexander.kapshuk@gmail.com> |
|---|---|
| Date | 2017-02-28 21:10 +0100 |
| Subject | [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. |
| Message-ID | <tfWfT-NX-1@gated-at.bofh.it> |
Use a single fmt string with appropriate verbs as conversion specifiers,
followed by the original string literals and the integer argument
instead of using a backslash to escape a new line embedded inbetween
quoted string literals passed as fmt arguments to dev_err() invoked in
drivers/staging/fbtft/fb_ssd1331.c.
Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
drivers/staging/fbtft/fb_ssd1331.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index 26f24e3..6d03041 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
for (i = 0; i < 63; i++) {
if (i > 0 && curves[i] < 2) {
- dev_err(par->info->device,
- "Illegal value in Grayscale Lookup Table at index %d. " \
- "Must be greater than 1\n", i);
+ dev_err(par->info->device, "%s %d. %s\n",
+ "Illegal value in Grayscale Lookup Table at index",
+ i,
+ "Must be greater than 1");
return -EINVAL;
}
acc += curves[i];
tmp[i] = acc;
if (acc > 180) {
- dev_err(par->info->device,
- "Illegal value(s) in Grayscale Lookup Table. " \
- "At index=%d, the accumulated value has exceeded 180\n", i);
+ dev_err(par->info->device, "%s%d, %s\n",
+ "Illegal value(s) in Grayscale Lookup Table. At index=",
+ i,
+ "the accumulated value has exceeded 180");
return -EINVAL;
}
}
--
2.10.2
[toc] | [next] | [standalone]
| From | Joe Perches <joe@perches.com> |
|---|---|
| Date | 2017-02-28 21:40 +0100 |
| Subject | Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. |
| Message-ID | <tfWIW-Ym-15@gated-at.bofh.it> |
| In reply to | #1589735 |
On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote:
> Use a single fmt string with appropriate verbs as conversion specifiers,
> followed by the original string literals and the integer argument
> instead of using a backslash to escape a new line embedded inbetween
> quoted string literals passed as fmt arguments to dev_err() invoked in
> drivers/staging/fbtft/fb_ssd1331.c.
trivia:
> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
> index 26f24e3..6d03041 100644
> --- a/drivers/staging/fbtft/fb_ssd1331.c
> +++ b/drivers/staging/fbtft/fb_ssd1331.c
> @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>
> for (i = 0; i < 63; i++) {
> if (i > 0 && curves[i] < 2) {
> - dev_err(par->info->device,
> - "Illegal value in Grayscale Lookup Table at index %d. " \
> - "Must be greater than 1\n", i);
> + dev_err(par->info->device, "%s %d. %s\n",
> + "Illegal value in Grayscale Lookup Table at index",
Most prefer the use of invalid not illegal.
[toc] | [prev] | [next] | [standalone]
| From | Alexander Kapshuk <alexander.kapshuk@gmail.com> |
|---|---|
| Date | 2017-02-28 22:40 +0100 |
| Subject | Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. |
| Message-ID | <tfXF0-1ys-7@gated-at.bofh.it> |
| In reply to | #1589758 |
On Tue, Feb 28, 2017 at 10:34 PM, Joe Perches <joe@perches.com> wrote:
> On Tue, 2017-02-28 at 21:52 +0200, Alexander Kapshuk wrote:
>> Use a single fmt string with appropriate verbs as conversion specifiers,
>> followed by the original string literals and the integer argument
>> instead of using a backslash to escape a new line embedded inbetween
>> quoted string literals passed as fmt arguments to dev_err() invoked in
>> drivers/staging/fbtft/fb_ssd1331.c.
>
> trivia:
>
>> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
>> index 26f24e3..6d03041 100644
>> --- a/drivers/staging/fbtft/fb_ssd1331.c
>> +++ b/drivers/staging/fbtft/fb_ssd1331.c
>> @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>>
>> for (i = 0; i < 63; i++) {
>> if (i > 0 && curves[i] < 2) {
>> - dev_err(par->info->device,
>> - "Illegal value in Grayscale Lookup Table at index %d. " \
>> - "Must be greater than 1\n", i);
>> + dev_err(par->info->device, "%s %d. %s\n",
>> + "Illegal value in Grayscale Lookup Table at index",
>
> Most prefer the use of invalid not illegal.
>
Thanks for your feedback.
I don't mind substituting invalid for illegal, unless the maintainers
preferred to do that themselves instead.
My patch was addressing a checkpatch.pl warning only.
I'll wait a bit more to hear from the maintainers, before going ahead
and sending another patch in.
Thanks.
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2017-03-01 11:00 +0100 |
| Subject | Re: [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations. |
| Message-ID | <tg9d7-1fv-5@gated-at.bofh.it> |
| In reply to | #1589735 |
On Tue, Feb 28, 2017 at 09:52:44PM +0200, Alexander Kapshuk wrote:
> Use a single fmt string with appropriate verbs as conversion specifiers,
> followed by the original string literals and the integer argument
> instead of using a backslash to escape a new line embedded inbetween
> quoted string literals passed as fmt arguments to dev_err() invoked in
> drivers/staging/fbtft/fb_ssd1331.c.
>
> Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
> ---
> drivers/staging/fbtft/fb_ssd1331.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
> index 26f24e3..6d03041 100644
> --- a/drivers/staging/fbtft/fb_ssd1331.c
> +++ b/drivers/staging/fbtft/fb_ssd1331.c
> @@ -129,17 +129,19 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
>
> for (i = 0; i < 63; i++) {
> if (i > 0 && curves[i] < 2) {
> - dev_err(par->info->device,
> - "Illegal value in Grayscale Lookup Table at index %d. " \
> - "Must be greater than 1\n", i);
> + dev_err(par->info->device, "%s %d. %s\n",
> + "Illegal value in Grayscale Lookup Table at index",
> + i,
> + "Must be greater than 1");
Huh? This should just be:
"Illegal value in Grayscale Lookup Table at index %d. Must be greater than 1\n",
i);
Don't split the string for no good reason.
> return -EINVAL;
> }
> acc += curves[i];
> tmp[i] = acc;
> if (acc > 180) {
> - dev_err(par->info->device,
> - "Illegal value(s) in Grayscale Lookup Table. " \
> - "At index=%d, the accumulated value has exceeded 180\n", i);
> + dev_err(par->info->device, "%s%d, %s\n",
> + "Illegal value(s) in Grayscale Lookup Table. At index=",
> + i,
> + "the accumulated value has exceeded 180");
Same here.
please fix.
thanks,
greg k-h
[toc] | [prev] | [next] | [standalone]
| From | Alexander Kapshuk <alexander.kapshuk@gmail.com> |
|---|---|
| Date | 2017-03-04 10:10 +0100 |
| Subject | [PATCH] staging/fbtft: Hush checkpatch.pl warning about unnecessary line continuations |
| Message-ID | <thdRn-6PZ-9@gated-at.bofh.it> |
| In reply to | #1590148 |
Use a single string literal as the fmt argument passed to dev_err()
instead of multiple string literals split with an embedded backslash
character.
Signed-off-by: Alexander Kapshuk <alexander.kapshuk@gmail.com>
---
drivers/staging/fbtft/fb_ssd1331.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ssd1331.c b/drivers/staging/fbtft/fb_ssd1331.c
index 26f24e3..9aa9864 100644
--- a/drivers/staging/fbtft/fb_ssd1331.c
+++ b/drivers/staging/fbtft/fb_ssd1331.c
@@ -130,16 +130,16 @@ static int set_gamma(struct fbtft_par *par, u32 *curves)
for (i = 0; i < 63; i++) {
if (i > 0 && curves[i] < 2) {
dev_err(par->info->device,
- "Illegal value in Grayscale Lookup Table at index %d. " \
- "Must be greater than 1\n", i);
+ "Illegal value in Grayscale Lookup Table at index %d. Must be greater than 1\n",
+ i);
return -EINVAL;
}
acc += curves[i];
tmp[i] = acc;
if (acc > 180) {
dev_err(par->info->device,
- "Illegal value(s) in Grayscale Lookup Table. " \
- "At index=%d, the accumulated value has exceeded 180\n", i);
+ "Illegal value(s) in Grayscale Lookup Table. At index=%d, the accumulated value has exceeded 180\n",
+ i);
return -EINVAL;
}
}
--
2.10.2
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web