Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585762 > unrolled thread

[PATCH 1/2] drm/sti: remove unused variable

Back to article view | Back to linux.kernel

Contents

  [PATCH 1/2] drm/sti: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
    [PATCH 2/2] drm/sti: remove unused sti_drm_dbg_cleanup Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
    Re: [PATCH 1/2] drm/sti: remove unused variable Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-02-22 10:10 +0100

#1585762 — [PATCH 1/2] drm/sti: remove unused variable

One variable was left behind after its user got removed and we should now
delete the declaration as well:

drivers/gpu/drm/sti/sti_vtg.c: In function 'vtg_probe':
drivers/gpu/drm/sti/sti_vtg.c:392:22: error: unused variable 'np' [-Werror=unused-variable]

Fixes: 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/sti/sti_vtg.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index 943bce56692e..2dcba1d3a122 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -389,7 +389,6 @@ static irqreturn_t vtg_irq(int irq, void *arg)
 static int vtg_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
-	struct device_node *np;
 	struct sti_vtg *vtg;
 	struct resource *res;
 	int ret;
-- 
2.9.0

[toc] | [next] | [standalone]

#1585766 — [PATCH 2/2] drm/sti: remove unused sti_drm_dbg_cleanup

A cleanup patch just introduced this function, but no user, leading
to a compile-time warning:

drivers/gpu/drm/sti/sti_drv.c:120:13: error: 'sti_drm_dbg_cleanup' defined but not used [-Werror=unused-function]

It would be logical that we should actually call this function, but
I couldn't see from where, so this patch just shuts up the warning,
which may be the wrong approach.

Fixes: 5e60f595d6ca ("drm/sti: use atomic_helper for commit")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/sti/sti_drv.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index e6c1646b9c53..20fc0fbfa849 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -117,15 +117,6 @@ static int sti_drm_dbg_init(struct drm_minor *minor)
 	return ret;
 }
 
-static void sti_drm_dbg_cleanup(struct drm_minor *minor)
-{
-	drm_debugfs_remove_files(sti_drm_dbg_list,
-				 ARRAY_SIZE(sti_drm_dbg_list), minor);
-
-	drm_debugfs_remove_files((struct drm_info_list *)&sti_drm_fps_fops,
-				 1, minor);
-}
-
 static int sti_atomic_check(struct drm_device *dev,
 			    struct drm_atomic_state *state)
 {
-- 
2.9.0

[toc] | [prev] | [next] | [standalone]

#1586006

2017-02-21 23:03 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> One variable was left behind after its user got removed and we should now
> delete the declaration as well:
>
> drivers/gpu/drm/sti/sti_vtg.c: In function 'vtg_probe':
> drivers/gpu/drm/sti/sti_vtg.c:392:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Fixes: 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hi Arnd,

Thanks for the patch but Vincent has send a patch for the both issues
issues a day ago :-)
https://lists.freedesktop.org/archives/dri-devel/2017-February/133346.html

Benjamin

> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 943bce56692e..2dcba1d3a122 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -389,7 +389,6 @@ static irqreturn_t vtg_irq(int irq, void *arg)
>  static int vtg_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *np;
>         struct sti_vtg *vtg;
>         struct resource *res;
>         int ret;
> --
> 2.9.0
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web