Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1586006

Re: [PATCH 1/2] drm/sti: remove unused variable

Show all headers | View raw

2017-02-21 23:03 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> One variable was left behind after its user got removed and we should now
> delete the declaration as well:
>
> drivers/gpu/drm/sti/sti_vtg.c: In function 'vtg_probe':
> drivers/gpu/drm/sti/sti_vtg.c:392:22: error: unused variable 'np' [-Werror=unused-variable]
>
> Fixes: 0c7ff84f7f9d ("drm/sti: remove deprecated legacy vtg slave")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Hi Arnd,

Thanks for the patch but Vincent has send a patch for the both issues
issues a day ago :-)
https://lists.freedesktop.org/archives/dri-devel/2017-February/133346.html

Benjamin

> ---
>  drivers/gpu/drm/sti/sti_vtg.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index 943bce56692e..2dcba1d3a122 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -389,7 +389,6 @@ static irqreturn_t vtg_irq(int irq, void *arg)
>  static int vtg_probe(struct platform_device *pdev)
>  {
>         struct device *dev = &pdev->dev;
> -       struct device_node *np;
>         struct sti_vtg *vtg;
>         struct resource *res;
>         int ret;
> --
> 2.9.0
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drm/sti: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
  [PATCH 2/2] drm/sti: remove unused sti_drm_dbg_cleanup Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
  Re: [PATCH 1/2] drm/sti: remove unused variable Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-02-22 10:10 +0100

csiph-web