Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1585766

[PATCH 2/2] drm/sti: remove unused sti_drm_dbg_cleanup

Show all headers | View raw

A cleanup patch just introduced this function, but no user, leading
to a compile-time warning:

drivers/gpu/drm/sti/sti_drv.c:120:13: error: 'sti_drm_dbg_cleanup' defined but not used [-Werror=unused-function]

It would be logical that we should actually call this function, but
I couldn't see from where, so this patch just shuts up the warning,
which may be the wrong approach.

Fixes: 5e60f595d6ca ("drm/sti: use atomic_helper for commit")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/sti/sti_drv.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_drv.c b/drivers/gpu/drm/sti/sti_drv.c
index e6c1646b9c53..20fc0fbfa849 100644
--- a/drivers/gpu/drm/sti/sti_drv.c
+++ b/drivers/gpu/drm/sti/sti_drv.c
@@ -117,15 +117,6 @@ static int sti_drm_dbg_init(struct drm_minor *minor)
 	return ret;
 }
 
-static void sti_drm_dbg_cleanup(struct drm_minor *minor)
-{
-	drm_debugfs_remove_files(sti_drm_dbg_list,
-				 ARRAY_SIZE(sti_drm_dbg_list), minor);
-
-	drm_debugfs_remove_files((struct drm_info_list *)&sti_drm_fps_fops,
-				 1, minor);
-}
-
 static int sti_atomic_check(struct drm_device *dev,
 			    struct drm_atomic_state *state)
 {
-- 
2.9.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] drm/sti: remove unused variable Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
  [PATCH 2/2] drm/sti: remove unused sti_drm_dbg_cleanup Arnd Bergmann <arnd@arndb.de> - 2017-02-21 23:10 +0100
  Re: [PATCH 1/2] drm/sti: remove unused variable Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-02-22 10:10 +0100

csiph-web