Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1681054 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-07-04 17:30 +0200 |
| Last post | 2017-07-05 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case Colin King <colin.king@canonical.com> - 2017-07-04 17:30 +0200
Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case David Miller <davem@davemloft.net> - 2017-07-05 10:10 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-07-04 17:30 +0200 |
| Subject | [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case |
| Message-ID | <tZxW2-1JA-17@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
Currently the non-error path where val is greater than zero falls through
to the default case that sets the error return to -EINVAL. Add in
the missing break.
Detected by CoverityScan, CID#1449376 ("Missing break in switch")
Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
net/core/filter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 94169572d002..c7f737058d89 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
tp->snd_cwnd_clamp = val;
tp->snd_ssthresh = val;
}
+ break;
default:
ret = -EINVAL;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-07-05 10:10 +0200 |
| Subject | Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case |
| Message-ID | <tZNxL-3Ho-3@gated-at.bofh.it> |
| In reply to | #1681054 |
From: Colin King <colin.king@canonical.com>
Date: Tue, 4 Jul 2017 16:21:12 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
>
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
>
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web