Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
Date	2017-07-05 10:10 +0200
Message-ID	<tZNxL-3Ho-3@gated-at.bofh.it> (permalink)
References	<tZxW2-1JA-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Tue,  4 Jul 2017 16:21:12 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
> Currently the non-error path where val is greater than zero falls through
> to the default case that sets the error return to -EINVAL. Add in
> the missing break.
> 
> Detected by CoverityScan, CID#1449376 ("Missing break in switch")
> 
> Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case Colin King <colin.king@canonical.com> - 2017-07-04 17:30 +0200
  Re: [PATCH][bpf-next] bpf: add missing break in for the  TCP_BPF_SNDCWND_CLAMP case David Miller <davem@davemloft.net> - 2017-07-05 10:10 +0200

csiph-web