[PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case

From	Colin King <colin.king@canonical.com>
Newsgroups	linux.kernel
Subject	[PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case
Date	2017-07-04 17:30 +0200
Message-ID	<tZxW2-1JA-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

There appears to be a missing break in the TCP_BPF_SNDCWND_CLAMP case.
Currently the non-error path where val is greater than zero falls through
to the default case that sets the error return to -EINVAL. Add in
the missing break.

Detected by CoverityScan, CID#1449376 ("Missing break in switch")

Fixes: 13bf96411ad2 ("bpf: Adds support for setting sndcwnd clamp")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 net/core/filter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/core/filter.c b/net/core/filter.c
index 94169572d002..c7f737058d89 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -2867,6 +2867,7 @@ BPF_CALL_5(bpf_setsockopt, struct bpf_sock_ops_kern *, bpf_sock,
 					tp->snd_cwnd_clamp = val;
 					tp->snd_ssthresh = val;
 				}
+				break;
 			default:
 				ret = -EINVAL;
 			}
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH][bpf-next] bpf: add missing break in for the TCP_BPF_SNDCWND_CLAMP case Colin King <colin.king@canonical.com> - 2017-07-04 17:30 +0200
  Re: [PATCH][bpf-next] bpf: add missing break in for the  TCP_BPF_SNDCWND_CLAMP case David Miller <davem@davemloft.net> - 2017-07-05 10:10 +0200

csiph-web