Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678552 > unrolled thread

[PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

Started by"Gustavo A. R. Silva" <garsilva@embeddedor.com>
First post2017-06-30 09:20 +0200
Last post2017-07-17 07:00 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 09:20 +0200
    Re: [PATCH] devfreq: rk3399_dmc: fix error code in  rk3399_dmcfreq_probe() Chanwoo Choi <cw00.choi@samsung.com> - 2017-06-30 10:10 +0200
      Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-01 10:00 +0200
        [PATCH v2] devfreq: rk3399_dmc: fix error return code in  rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-03 15:00 +0200
        Re: [PATCH] devfreq: rk3399_dmc: fix error code in  rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 07:00 +0200

#1678552 — [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-06-30 09:20 +0200
Subject[PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()
Message-ID<tXYnE-2qb-15@gated-at.bofh.it>
Print and propagate the return value of platform_get_irq on failure.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/devfreq/rk3399_dmc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 40a2499..1b89ebb 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
-		return -EINVAL;
+		dev_err(&pdev->dev,
+			"Cannot get the dmc interrupt resource: %d\n", irq);
+		return irq;
 	}
 	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
 	if (!data)
-- 
2.5.0

[toc] | [next] | [standalone]

#1678585 — Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

FromChanwoo Choi <cw00.choi@samsung.com>
Date2017-06-30 10:10 +0200
SubjectRe: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()
Message-ID<tXZa2-2WX-17@gated-at.bofh.it>
In reply to#1678552
Hi,

On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/devfreq/rk3399_dmc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 40a2499..1b89ebb 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
> -		return -EINVAL;
> +		dev_err(&pdev->dev,
> +			"Cannot get the dmc interrupt resource: %d\n", irq);
> +		return irq;
>  	}
>  	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>  	if (!data)
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1679281

FromMyungJoo Ham <myungjoo.ham@samsung.com>
Date2017-07-01 10:00 +0200
Message-ID<tYltT-fx-1@gated-at.bofh.it>
In reply to#1678585
On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
>> Print and propagate the return value of platform_get_irq on failure.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>> ---
>>  drivers/devfreq/rk3399_dmc.c | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>> index 40a2499..1b89ebb 100644
>> --- a/drivers/devfreq/rk3399_dmc.c
>> +++ b/drivers/devfreq/rk3399_dmc.c
>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>>
>>       irq = platform_get_irq(pdev, 0);
>>       if (irq < 0) {
>> -             dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
>> -             return -EINVAL;
>> +             dev_err(&pdev->dev,
>> +                     "Cannot get the dmc interrupt resource: %d\n", irq);
>> +             return irq;
>>       }
>>       data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>>       if (!data)
>>
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

>
> --
> Best Regards,
> Chanwoo Choi
> Samsung Electronics



-- 
MyungJoo Ham, Ph.D.
S/W Center, Samsung Electronics

[toc] | [prev] | [next] | [standalone]

#1679979 — [PATCH v2] devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe()

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-07-03 15:00 +0200
Subject[PATCH v2] devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe()
Message-ID<tZ97j-1Az-17@gated-at.bofh.it>
In reply to#1679281
platform_get_irq() returns an error code, but the rk3399_dmc
driver ignores it and always returns -EINVAL. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
 Rewrite commit message.
 
 drivers/devfreq/rk3399_dmc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 40a2499..1b89ebb 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
-		return -EINVAL;
+		dev_err(&pdev->dev,
+			"Cannot get the dmc interrupt resource: %d\n", irq);
+		return irq;
 	}
 	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
 	if (!data)
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1688647 — Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

From"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date2017-07-17 07:00 +0200
SubjectRe: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()
Message-ID<u46iu-oa-5@gated-at.bofh.it>
In reply to#1679281

On 07/01/2017 02:50 AM, MyungJoo Ham wrote:
> On Fri, Jun 30, 2017 at 5:02 PM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>> Hi,
>>
>> On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
>>> Print and propagate the return value of platform_get_irq on failure.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
>>> ---
>>>  drivers/devfreq/rk3399_dmc.c | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
>>> index 40a2499..1b89ebb 100644
>>> --- a/drivers/devfreq/rk3399_dmc.c
>>> +++ b/drivers/devfreq/rk3399_dmc.c
>>> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>>>
>>>       irq = platform_get_irq(pdev, 0);
>>>       if (irq < 0) {
>>> -             dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
>>> -             return -EINVAL;
>>> +             dev_err(&pdev->dev,
>>> +                     "Cannot get the dmc interrupt resource: %d\n", irq);
>>> +             return irq;
>>>       }
>>>       data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>>>       if (!data)
>>>
>>
>> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>

Thank you, Chanwoo and MyungJoo.

-- 
Gustavo A. R. Silva

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web