Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678585

Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe()

Show all headers | View raw

Hi,

On 2017년 06월 30일 16:15, Gustavo A. R. Silva wrote:
> Print and propagate the return value of platform_get_irq on failure.
> 
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>  drivers/devfreq/rk3399_dmc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 40a2499..1b89ebb 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
>  
>  	irq = platform_get_irq(pdev, 0);
>  	if (irq < 0) {
> -		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
> -		return -EINVAL;
> +		dev_err(&pdev->dev,
> +			"Cannot get the dmc interrupt resource: %d\n", irq);
> +		return irq;
>  	}
>  	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
>  	if (!data)
> 

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 09:20 +0200
  Re: [PATCH] devfreq: rk3399_dmc: fix error code in  rk3399_dmcfreq_probe() Chanwoo Choi <cw00.choi@samsung.com> - 2017-06-30 10:10 +0200
    Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-01 10:00 +0200
      [PATCH v2] devfreq: rk3399_dmc: fix error return code in  rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-03 15:00 +0200

csiph-web