Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1679979

[PATCH v2] devfreq: rk3399_dmc: fix error return code in rk3399_dmcfreq_probe()

Show all headers | View raw

platform_get_irq() returns an error code, but the rk3399_dmc
driver ignores it and always returns -EINVAL. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly.

Notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print and propagate the return value of platform_get_irq on failure.

Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
Changes in v2:
 Rewrite commit message.
 
 drivers/devfreq/rk3399_dmc.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 40a2499..1b89ebb 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -336,8 +336,9 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		dev_err(&pdev->dev, "Cannot get the dmc interrupt resource\n");
-		return -EINVAL;
+		dev_err(&pdev->dev,
+			"Cannot get the dmc interrupt resource: %d\n", irq);
+		return irq;
 	}
 	data = devm_kzalloc(dev, sizeof(struct rk3399_dmcfreq), GFP_KERNEL);
 	if (!data)
-- 
2.5.0

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 09:20 +0200
  Re: [PATCH] devfreq: rk3399_dmc: fix error code in  rk3399_dmcfreq_probe() Chanwoo Choi <cw00.choi@samsung.com> - 2017-06-30 10:10 +0200
    Re: [PATCH] devfreq: rk3399_dmc: fix error code in rk3399_dmcfreq_probe() MyungJoo Ham <myungjoo.ham@samsung.com> - 2017-07-01 10:00 +0200
      [PATCH v2] devfreq: rk3399_dmc: fix error return code in  rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-03 15:00 +0200
      Re: [PATCH] devfreq: rk3399_dmc: fix error code in  rk3399_dmcfreq_probe() "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-07-17 07:00 +0200

csiph-web