Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1676459 > unrolled thread
| Started by | Joerg Roedel <joro@8bytes.org> |
|---|---|
| First post | 2017-06-28 11:00 +0200 |
| Last post | 2017-06-28 12:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 11:00 +0200
Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-28 12:10 +0200
Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 12:30 +0200
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Date | 2017-06-28 11:00 +0200 |
| Subject | Re: [PATCH] iommu/vt-d: constify intel_dma_ops. |
| Message-ID | <tXgZk-4AZ-25@gated-at.bofh.it> |
On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote: > File size before: > text data bss dec hex filename > 32765 758 1824 35347 8a13 drivers/iommu/intel-iommu.o > > File size After adding 'const': > text data bss dec hex filename > 32925 598 1824 35347 8a13 drivers/iommu/intel-iommu.o What is the point of those commit-messages? They just show that the struct moved from data to the text segment. The overall size doesn't change much. Joerg
[toc] | [next] | [standalone]
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-06-28 12:10 +0200 |
| Message-ID | <tXi54-5sM-19@gated-at.bofh.it> |
| In reply to | #1676459 |
Hi, Most dma_map_ops structures are never modified. Constify these structures such that these can be write-protected. This file size diff will show the difference between data and text segment. Thanks, ~arvind On Wednesday 28 June 2017 02:23 PM, Joerg Roedel wrote: > On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote: >> File size before: >> text data bss dec hex filename >> 32765 758 1824 35347 8a13 drivers/iommu/intel-iommu.o >> >> File size After adding 'const': >> text data bss dec hex filename >> 32925 598 1824 35347 8a13 drivers/iommu/intel-iommu.o > What is the point of those commit-messages? They just show that the > struct moved from data to the text segment. The overall size doesn't > change much. > > > > Joerg >
[toc] | [prev] | [next] | [standalone]
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Date | 2017-06-28 12:30 +0200 |
| Message-ID | <tXiop-5z2-19@gated-at.bofh.it> |
| In reply to | #1676509 |
On Wed, Jun 28, 2017 at 03:31:16PM +0530, Arvind Yadav wrote: > Most dma_map_ops structures are never modified. Constify these > structures such that these can be write-protected. This file size diff > will show the difference between data and text segment. I know what the diff shows, but it doesn't matter for this patch because thats just an implementation detail of the compiler. The real reason for making it 'const' is to write-protect them, and that should be clear in the commit-message. Joerg
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web