Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1676509

Re: [PATCH] iommu/vt-d: constify intel_dma_ops.

From Arvind Yadav <arvind.yadav.cs@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] iommu/vt-d: constify intel_dma_ops.
Date 2017-06-28 12:10 +0200
Message-ID <tXi54-5sM-19@gated-at.bofh.it> (permalink)
References <tRR5w-6If-27@gated-at.bofh.it> <tXgZk-4AZ-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi,

Most dma_map_ops structures are never modified. Constify these
structures such that these can be write-protected. This file size diff
will show the difference between data and text segment.

Thanks,
~arvind

On Wednesday 28 June 2017 02:23 PM, Joerg Roedel wrote:
> On Tue, Jun 13, 2017 at 03:48:34PM +0530, Arvind Yadav wrote:
>> File size before:
>>     text	   data	    bss	    dec	    hex	filename
>>    32765	    758	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
>>
>> File size After adding 'const':
>>     text	   data	    bss	    dec	    hex	filename
>>    32925	    598	   1824	  35347	   8a13	drivers/iommu/intel-iommu.o
> What is the point of those commit-messages? They just show that the
> struct moved from data to the text segment. The overall size doesn't
> change much.
>
>
>
> 	Joerg
>

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 11:00 +0200
  Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-28 12:10 +0200
    Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 12:30 +0200

csiph-web