Re: [PATCH] iommu/vt-d: constify intel_dma_ops.

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] iommu/vt-d: constify intel_dma_ops.
Date	2017-06-28 12:30 +0200
Message-ID	<tXiop-5z2-19@gated-at.bofh.it> (permalink)
References	<tRR5w-6If-27@gated-at.bofh.it> <tXgZk-4AZ-25@gated-at.bofh.it> <tXi54-5sM-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 28, 2017 at 03:31:16PM +0530, Arvind Yadav wrote:
> Most dma_map_ops structures are never modified. Constify these
> structures such that these can be write-protected. This file size diff
> will show the difference between data and text segment.

I know what the diff shows, but it doesn't matter for this patch because
thats just an implementation detail of the compiler. The real reason for
making it 'const' is to write-protect them, and that should be clear in
the commit-message.

	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 11:00 +0200
  Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-06-28 12:10 +0200
    Re: [PATCH] iommu/vt-d: constify intel_dma_ops. Joerg Roedel <joro@8bytes.org> - 2017-06-28 12:30 +0200

csiph-web