Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673382 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2017-06-23 10:50 +0200 |
| Last post | 2017-06-26 16:20 +0200 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] EDAC, pnd2_edac: make function sbi_send static Colin King <colin.king@canonical.com> - 2017-06-23 10:50 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-23 11:00 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static "Luck, Tony" <tony.luck@intel.com> - 2017-06-23 22:50 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-26 16:20 +0200
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2017-06-23 10:50 +0200 |
| Subject | [PATCH] EDAC, pnd2_edac: make function sbi_send static |
| Message-ID | <tVsrU-8kl-25@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
The function sbi_send is local to just pnd2_edac.c and does not need to
be in global scope, so make it static.
Cleans up sparse warning:
symbol 'sbi_send' was not declared. Should it be static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/edac/pnd2_edac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 1cad5a9af8d0..4efdca1dad5a 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -131,7 +131,7 @@ static struct mem_ctl_info *pnd2_mci;
#ifdef CONFIG_X86_INTEL_SBI_APL
#include "linux/platform_data/sbi_apl.h"
-int sbi_send(int port, int off, int op, u32 *data)
+static int sbi_send(int port, int off, int op, u32 *data)
{
struct sbi_apl_message sbi_arg;
int ret, read = 0;
@@ -160,7 +160,7 @@ int sbi_send(int port, int off, int op, u32 *data)
return ret;
}
#else
-int sbi_send(int port, int off, int op, u32 *data)
+static int sbi_send(int port, int off, int op, u32 *data)
{
return -EUNATCH;
}
--
2.11.0
[toc] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-06-23 11:00 +0200 |
| Message-ID | <tVsBA-8nM-9@gated-at.bofh.it> |
| In reply to | #1673382 |
On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function sbi_send is local to just pnd2_edac.c and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'sbi_send' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/pnd2_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
> index 1cad5a9af8d0..4efdca1dad5a 100644
> --- a/drivers/edac/pnd2_edac.c
> +++ b/drivers/edac/pnd2_edac.c
> @@ -131,7 +131,7 @@ static struct mem_ctl_info *pnd2_mci;
>
> #ifdef CONFIG_X86_INTEL_SBI_APL
> #include "linux/platform_data/sbi_apl.h"
> -int sbi_send(int port, int off, int op, u32 *data)
> +static int sbi_send(int port, int off, int op, u32 *data)
> {
> struct sbi_apl_message sbi_arg;
> int ret, read = 0;
> @@ -160,7 +160,7 @@ int sbi_send(int port, int off, int op, u32 *data)
> return ret;
> }
> #else
> -int sbi_send(int port, int off, int op, u32 *data)
> +static int sbi_send(int port, int off, int op, u32 *data)
Tony, were those supposed to be used somewhere outside of the driver,
i.e., that CONFIG_X86_INTEL_SBI_APL thing?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [next] | [standalone]
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Date | 2017-06-23 22:50 +0200 |
| Message-ID | <tVDGF-6Vq-7@gated-at.bofh.it> |
| In reply to | #1673389 |
On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote: > On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > -int sbi_send(int port, int off, int op, u32 *data) > > +static int sbi_send(int port, int off, int op, u32 *data) > > Tony, were those supposed to be used somewhere outside of the driver, > i.e., that CONFIG_X86_INTEL_SBI_APL thing? No. This function is internal and can be static. The CONFIG_X86_INTEL_SBI_APL thing is about sbi_apl_commit() while is still waiting for a sideband driver that defines it to be pushed upstream. -Tony
[toc] | [prev] | [next] | [standalone]
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Date | 2017-06-26 16:20 +0200 |
| Message-ID | <tWD1U-3pT-13@gated-at.bofh.it> |
| In reply to | #1673382 |
On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function sbi_send is local to just pnd2_edac.c and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'sbi_send' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/edac/pnd2_edac.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web