Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1673862
| From | "Luck, Tony" <tony.luck@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static |
| Date | 2017-06-23 22:50 +0200 |
| Message-ID | <tVDGF-6Vq-7@gated-at.bofh.it> (permalink) |
| References | <tVsrU-8kl-25@gated-at.bofh.it> <tVsBA-8nM-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jun 23, 2017 at 10:58:24AM +0200, Borislav Petkov wrote: > On Fri, Jun 23, 2017 at 09:48:55AM +0100, Colin King wrote: > > From: Colin Ian King <colin.king@canonical.com> > > -int sbi_send(int port, int off, int op, u32 *data) > > +static int sbi_send(int port, int off, int op, u32 *data) > > Tony, were those supposed to be used somewhere outside of the driver, > i.e., that CONFIG_X86_INTEL_SBI_APL thing? No. This function is internal and can be static. The CONFIG_X86_INTEL_SBI_APL thing is about sbi_apl_commit() while is still waiting for a sideband driver that defines it to be pushed upstream. -Tony
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] EDAC, pnd2_edac: make function sbi_send static Colin King <colin.king@canonical.com> - 2017-06-23 10:50 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-23 11:00 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static "Luck, Tony" <tony.luck@intel.com> - 2017-06-23 22:50 +0200
Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-26 16:20 +0200
csiph-web