Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1673382

[PATCH] EDAC, pnd2_edac: make function sbi_send static

Show all headers | View raw

From: Colin Ian King <colin.king@canonical.com>

The function sbi_send is local to just pnd2_edac.c and does not need to
be in global scope, so make it static.

Cleans up sparse warning:
symbol 'sbi_send' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/edac/pnd2_edac.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c
index 1cad5a9af8d0..4efdca1dad5a 100644
--- a/drivers/edac/pnd2_edac.c
+++ b/drivers/edac/pnd2_edac.c
@@ -131,7 +131,7 @@ static struct mem_ctl_info *pnd2_mci;
 
 #ifdef CONFIG_X86_INTEL_SBI_APL
 #include "linux/platform_data/sbi_apl.h"
-int sbi_send(int port, int off, int op, u32 *data)
+static int sbi_send(int port, int off, int op, u32 *data)
 {
 	struct sbi_apl_message sbi_arg;
 	int ret, read = 0;
@@ -160,7 +160,7 @@ int sbi_send(int port, int off, int op, u32 *data)
 	return ret;
 }
 #else
-int sbi_send(int port, int off, int op, u32 *data)
+static int sbi_send(int port, int off, int op, u32 *data)
 {
 	return -EUNATCH;
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] EDAC, pnd2_edac: make function sbi_send static Colin King <colin.king@canonical.com> - 2017-06-23 10:50 +0200
  Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-23 11:00 +0200
    Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static "Luck, Tony" <tony.luck@intel.com> - 2017-06-23 22:50 +0200
  Re: [PATCH] EDAC, pnd2_edac: make function sbi_send static Borislav Petkov <bp@alien8.de> - 2017-06-26 16:20 +0200

csiph-web