Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1670833 > unrolled thread
| Started by | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| First post | 2017-06-20 16:50 +0200 |
| Last post | 2017-06-20 21:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-20 16:50 +0200
Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Dave Gerlach <d-gerlach@ti.com> - 2017-06-20 21:10 +0200
| From | Russell King - ARM Linux <linux@armlinux.org.uk> |
|---|---|
| Date | 2017-06-20 16:50 +0200 |
| Subject | Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers |
| Message-ID | <tUsDF-1rP-21@gated-at.bofh.it> |
On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
> + .arm
> + .align 3
> +
> +ENTRY(ti_emif_sram)
Will you ever want to have any of this code as Thumb?
> +extern inline void ti_emif_offsets(void)
> +{
"extern inline" is frowned upon in the kernel - any reason this
can't be "static inline" ?
Any reason not to provide a stub for when it's not configured,
and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
[toc] | [next] | [standalone]
| From | Dave Gerlach <d-gerlach@ti.com> |
|---|---|
| Date | 2017-06-20 21:10 +0200 |
| Message-ID | <tUwHf-4ad-9@gated-at.bofh.it> |
| In reply to | #1670833 |
Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> + .arm
>> + .align 3
>> +
>> +ENTRY(ti_emif_sram)
>
> Will you ever want to have any of this code as Thumb?
I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.
>
>> +extern inline void ti_emif_offsets(void)
>> +{
>
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?
It should be static.
>
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
>
No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.
Regards,
Dave
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web