Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date	2017-06-20 16:50 +0200
Message-ID	<tUsDF-1rP-21@gated-at.bofh.it> (permalink)
References	<tIUvE-5Pe-19@gated-at.bofh.it> <tIUvF-5Pe-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
> +	.arm
> +	.align 3
> +
> +ENTRY(ti_emif_sram)

Will you ever want to have any of this code as Thumb?

> +extern inline void ti_emif_offsets(void)
> +{

"extern inline" is frowned upon in the kernel - any reason this
can't be "static inline" ?

Any reason not to provide a stub for when it's not configured,
and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable  suspend/resume handlers Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-20 16:50 +0200
  Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable  suspend/resume handlers Dave Gerlach <d-gerlach@ti.com> - 2017-06-20 21:10 +0200

csiph-web