Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers

From	Dave Gerlach <d-gerlach@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers
Date	2017-06-20 21:10 +0200
Message-ID	<tUwHf-4ad-9@gated-at.bofh.it> (permalink)
References	<tIUvE-5Pe-19@gated-at.bofh.it> <tIUvF-5Pe-29@gated-at.bofh.it> <tUsDF-1rP-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,
On 06/20/2017 09:42 AM, Russell King - ARM Linux wrote:
> On Fri, May 19, 2017 at 12:57:08PM -0500, Dave Gerlach wrote:
>> +	.arm
>> +	.align 3
>> +
>> +ENTRY(ti_emif_sram)
> 
> Will you ever want to have any of this code as Thumb?

I cannot see any requirement for that. I will say it is tested and
inter-operates happily with CONFIG_THUMB_KERNEL, but because it's constrained to
am335x and am437x I don't think there are unknown situations where every single
instruction must be THUMB.

> 
>> +extern inline void ti_emif_offsets(void)
>> +{
> 
> "extern inline" is frowned upon in the kernel - any reason this
> can't be "static inline" ?

It should be static.

> 
> Any reason not to provide a stub for when it's not configured,
> and eliminate the ifdef in arch/arm/kernel/asm-offsets.c ?
> 

No, I just was following the ifdef example set by others in the file, a stub
would be cleaner I agree.

Regards,
Dave

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable  suspend/resume handlers Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-20 16:50 +0200
  Re: [PATCH v2 2/2] memory: ti-emif-sram: introduce relocatable  suspend/resume handlers Dave Gerlach <d-gerlach@ti.com> - 2017-06-20 21:10 +0200

csiph-web