Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1662241 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2017-06-09 12:20 +0200 |
| Last post | 2017-06-12 10:10 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:20 +0200
Re: [PATCH] phy: cpcap-usb: add MUSB dependency Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-09 13:50 +0200
Re: [PATCH] phy: cpcap-usb: add MUSB dependency Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-09 14:10 +0200
Re: [PATCH] phy: cpcap-usb: add MUSB dependency Tony Lindgren <tony@atomide.com> - 2017-06-12 10:10 +0200
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2017-06-09 12:20 +0200 |
| Subject | [PATCH] phy: cpcap-usb: add MUSB dependency |
| Message-ID | <tQpbk-h3-9@gated-at.bofh.it> |
When MUSB is a loadable module, we get a link error for a built-in
CPCAP driver:
drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
This adds a Kconfig dependency to prevent this broken configuration,
enforcing that CPCAP can only be a module when MUSB is also a module.
Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/phy/motorola/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
index 91a46cffd639..6bb7d6bdf1bf 100644
--- a/drivers/phy/motorola/Kconfig
+++ b/drivers/phy/motorola/Kconfig
@@ -4,6 +4,7 @@
config PHY_CPCAP_USB
tristate "CPCAP PMIC USB PHY driver"
depends on USB_SUPPORT && IIO
+ depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
select GENERIC_PHY
select USB_PHY
help
--
2.9.0
[toc] | [next] | [standalone]
| From | Sebastian Reichel <sebastian.reichel@collabora.co.uk> |
|---|---|
| Date | 2017-06-09 13:50 +0200 |
| Message-ID | <tQqAr-Yw-49@gated-at.bofh.it> |
| In reply to | #1662241 |
[Multipart message — attachments visible in raw view] — view raw
Hi,
On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> When MUSB is a loadable module, we get a link error for a built-in
> CPCAP driver:
>
> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
>
> This adds a Kconfig dependency to prevent this broken configuration,
> enforcing that CPCAP can only be a module when MUSB is also a module.
>
> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
-- Sebastian
> ---
> drivers/phy/motorola/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
> index 91a46cffd639..6bb7d6bdf1bf 100644
> --- a/drivers/phy/motorola/Kconfig
> +++ b/drivers/phy/motorola/Kconfig
> @@ -4,6 +4,7 @@
> config PHY_CPCAP_USB
> tristate "CPCAP PMIC USB PHY driver"
> depends on USB_SUPPORT && IIO
> + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
> select GENERIC_PHY
> select USB_PHY
> help
> --
> 2.9.0
>
[toc] | [prev] | [next] | [standalone]
| From | Kishon Vijay Abraham I <kishon@ti.com> |
|---|---|
| Date | 2017-06-09 14:10 +0200 |
| Message-ID | <tQqTL-1lV-11@gated-at.bofh.it> |
| In reply to | #1662350 |
On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> Hi,
>
> On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
>> When MUSB is a loadable module, we get a link error for a built-in
>> CPCAP driver:
>>
>> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
>> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
>>
>> This adds a Kconfig dependency to prevent this broken configuration,
>> enforcing that CPCAP can only be a module when MUSB is also a module.
>>
>> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
merged, thanks!
-Kishon
>
> -- Sebastian
>
>> ---
>> drivers/phy/motorola/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
>> index 91a46cffd639..6bb7d6bdf1bf 100644
>> --- a/drivers/phy/motorola/Kconfig
>> +++ b/drivers/phy/motorola/Kconfig
>> @@ -4,6 +4,7 @@
>> config PHY_CPCAP_USB
>> tristate "CPCAP PMIC USB PHY driver"
>> depends on USB_SUPPORT && IIO
>> + depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
>> select GENERIC_PHY
>> select USB_PHY
>> help
>> --
>> 2.9.0
>>
[toc] | [prev] | [next] | [standalone]
| From | Tony Lindgren <tony@atomide.com> |
|---|---|
| Date | 2017-06-12 10:10 +0200 |
| Message-ID | <tRsA9-83t-7@gated-at.bofh.it> |
| In reply to | #1662363 |
* Kishon Vijay Abraham I <kishon@ti.com> [170609 05:04]:
>
>
> On Friday 09 June 2017 05:17 PM, Sebastian Reichel wrote:
> > Hi,
> >
> > On Fri, Jun 09, 2017 at 12:16:40PM +0200, Arnd Bergmann wrote:
> >> When MUSB is a loadable module, we get a link error for a built-in
> >> CPCAP driver:
> >>
> >> drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
> >> phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'
> >>
> >> This adds a Kconfig dependency to prevent this broken configuration,
> >> enforcing that CPCAP can only be a module when MUSB is also a module.
> >>
> >> Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
> >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> >
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>
> merged, thanks!
Yup thanks for fixing it.
Regards,
Tony
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web