[PATCH] phy: cpcap-usb: add MUSB dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] phy: cpcap-usb: add MUSB dependency
Date	2017-06-09 12:20 +0200
Message-ID	<tQpbk-h3-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

When MUSB is a loadable module, we get a link error for a built-in
CPCAP driver:

drivers/phy/built-in.o: In function `cpcap_usb_phy_remove':
phy-cpcap-usb.c:(.text+0xed9): undefined reference to `musb_mailbox'

This adds a Kconfig dependency to prevent this broken configuration,
enforcing that CPCAP can only be a module when MUSB is also a module.

Fixes: 68a1f7c9d470 ("phy: cpcap-usb: Add CPCAP PMIC USB support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/phy/motorola/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/phy/motorola/Kconfig b/drivers/phy/motorola/Kconfig
index 91a46cffd639..6bb7d6bdf1bf 100644
--- a/drivers/phy/motorola/Kconfig
+++ b/drivers/phy/motorola/Kconfig
@@ -4,6 +4,7 @@
 config PHY_CPCAP_USB
 	tristate "CPCAP PMIC USB PHY driver"
 	depends on USB_SUPPORT && IIO
+	depends on USB_MUSB_HDRC || USB_MUSB_HDRC=n
 	select GENERIC_PHY
 	select USB_PHY
 	help
-- 
2.9.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] phy: cpcap-usb: add MUSB dependency Arnd Bergmann <arnd@arndb.de> - 2017-06-09 12:20 +0200
  Re: [PATCH] phy: cpcap-usb: add MUSB dependency Sebastian Reichel <sebastian.reichel@collabora.co.uk> - 2017-06-09 13:50 +0200
    Re: [PATCH] phy: cpcap-usb: add MUSB dependency Kishon Vijay Abraham I <kishon@ti.com> - 2017-06-09 14:10 +0200
      Re: [PATCH] phy: cpcap-usb: add MUSB dependency Tony Lindgren <tony@atomide.com> - 2017-06-12 10:10 +0200

csiph-web